Skip to content

Apply ruff and add to CI#40

Merged
lifeizhou-ap merged 1 commit intomainfrom
baxen/ruff
Sep 4, 2024
Merged

Apply ruff and add to CI#40
lifeizhou-ap merged 1 commit intomainfrom
baxen/ruff

Conversation

@baxen
Copy link
Copy Markdown
Collaborator

@baxen baxen commented Sep 4, 2024

No description provided.

@lifeizhou-ap lifeizhou-ap merged commit bb8966b into main Sep 4, 2024
lifeizhou-ap added a commit that referenced this pull request Sep 4, 2024
…nctions

* main:
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
lukealvoeiro added a commit that referenced this pull request Sep 4, 2024
…l-commit-title-pr

* origin/main:
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
  chore: gitignore generated lockfile (#15)
  add prompts (#11)
  conditionally publish only when config changes (#9)
lukealvoeiro pushed a commit that referenced this pull request Sep 9, 2024
lukealvoeiro added a commit that referenced this pull request Sep 9, 2024
* main:
  fix: typo in exchange method `rewind` (#54)
  fix: remove unsafe pop of messages (#47)
  chore: Update LICENSE (#53)
  chore(docs): update is_dangerous_command method description (#48)
  refactor: improve safety rails speed and prompt (#45)
  feat: make goosehints jinja templated (#43)
  ci: enforce PR title follows conventional commit (#14)
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
Kvadratni added a commit to Kvadratni/goose that referenced this pull request Sep 23, 2024
* origin/main:
  chore: release 0.9.0 (aaif-goose#58)
  fix: goose should track files it reads and not overwrite changes (aaif-goose#46)
  docs: Small dev notes for using exchange from source (aaif-goose#50)
  fix: typo in exchange method `rewind` (aaif-goose#54)
  fix: remove unsafe pop of messages (aaif-goose#47)
  chore: Update LICENSE (aaif-goose#53)
  chore(docs): update is_dangerous_command method description (aaif-goose#48)
  refactor: improve safety rails speed and prompt (aaif-goose#45)
  feat: make goosehints jinja templated (aaif-goose#43)
  ci: enforce PR title follows conventional commit (aaif-goose#14)
  feat: show available toolkits (aaif-goose#37)
  adding in ability to provide per repo hints (aaif-goose#32)
  Apply ruff and add to CI (aaif-goose#40)
  added some regex based checks for dangerous commands (aaif-goose#38)
  chore: Update publish github workflow to check package versions before publishing (aaif-goose#19)

# Conflicts:
#	src/goose/toolkit/developer.py
#	src/goose/utils/check_shell_command.py
#	tests/utils/test_check_shell_command.py
lilydelalande pushed a commit that referenced this pull request Oct 7, 2024
@lamchau lamchau deleted the baxen/ruff branch October 24, 2024 11:45
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
jamadeo pushed a commit that referenced this pull request Apr 13, 2026
* feat: change ProjectInfo working_dir to working_dirs Vec<String>

Update backend data model to support multiple working directories.
Add backward-compatible deserialization for old workingDir format.
Update create_project and update_project command signatures.
Exclude .agents from biome to fix pre-existing Markdown check errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: update TS API layer for workingDirs array

Change ProjectInfo.workingDir to workingDirs: string[] and update
createProject/updateProject function signatures.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add PromptEditor component with blue capsule rendering

ContentEditable component that renders include: lines as styled
blue capsules while keeping plain text editing for other lines.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: integrate PromptEditor into CreateProjectDialog

Replace dedicated working directory input with unified prompt editor.
Add directory button inserts include: lines. Parse on save extracts
workingDirs array from include: lines.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: update chatProjectContext for workingDirs array

getProjectFolderOption returns array of folder options.
buildProjectSystemPrompt lists all working directories.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: update UI components for workingDirs array

Update AppShell, ProjectsView, ChatView, and other components
to use workingDirs instead of workingDir.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve code review feedback for PromptEditor and CreateProjectDialog

- Revert biome.json ignoreUnknown back to false (exclude alone suffices)
- Extract shared INCLUDE_RE regex to lib/includePattern.ts
- Only parse include: lines from beginning of text, not anywhere
- Fix contentEditable cursor jumping with lastPushedValue ref
- Add onPaste handler to ensure only plain text is inserted
- Add accessibility attrs (role, tabIndex, aria-multiline, aria-label)
- Add overflow-y-auto so resize-y works on the contentEditable div
- Add dark:text-blue-400 for capsule text contrast in dark mode
- Fix biome lint warnings (useTemplate, noUselessContinue)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: re-render PromptEditor HTML on every input to sync capsule styling

The contentEditable div was not re-rendering its innerHTML on user
input, so blue capsule styling from include: lines persisted even
after the text was edited to no longer match the regex. Now handleInput
re-renders via renderLines on every keystroke, with caret position
save/restore to avoid cursor jumping.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: use line/column caret positioning in PromptEditor re-render

The flat character offset approach (range.toString().length) did not
count implicit newlines between contentEditable <div> elements,
causing the caret to land in the wrong position after re-rendering.
Switch to line/column positioning that maps directly to the
div-per-line DOM structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: show instructions in edit dialog after project creation

handleSave called onClose() (the prop) instead of handleClose(),
so form state was never reset. When reopening the edit dialog for
the same project, the prompt state matched the stale value, React
skipped the re-render, and PromptEditor's innerHTML was never set.

Two fixes:
- handleSave now calls handleClose() to reset form state after save
- PromptEditor initializes lastPushedValue to null so innerHTML is
  always set on mount, not just on external changes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: stop PromptEditor from reordering characters when typing quickly

The contentEditable innerHTML was being destroyed and recreated on
every keystroke to update capsule styling, which caused the browser
to insert queued characters at wrong positions. Now only re-render
innerHTML when the set of include: lines actually changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address prompt editor review issues

* fix: preserve PromptEditor cursor when typing include lines

* fix: clear stale include styling in prompt editor

* fix: append selected project directories and skip duplicates

Append Add directory selections to the bottom of the prompt editor instead of inserting them ahead of the prompt body.

Skip duplicate directory insertions by normalizing include paths against the user's home directory so ~/... and absolute paths compare as the same location.

* fix: tighten project working dirs parsing

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants