Conversation
yarolegovich
commented
Mar 13, 2026
- fix auth deserialization
- remove non-thread-safe unused method
- rest uses timeout consistent with jsonrpc
- fix listTasks not using grpcutil error conversion
- fix uninintentional mutation possibility
- safety nil check
- fix wrong allocation target size
- fix rest not handling wrapped errors
- remove dead code
- fix missing jsonrpc error codes
- fix missing break after error
- fix subscribing to a different taskID in case of queue override
- fix response not sent for methods not returning values
- fix grpc error disambiguation
- fix panic write attempt to unbuffered channel
- fix potential error overriding by parse calls
- fix a2acompat
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a suite of critical bug fixes and stability enhancements across the A2A Go library, aiming to solidify its foundation before moving beyond the alpha stage. The changes primarily focus on ensuring consistent and robust error handling across gRPC, REST, and JSON-RPC communication protocols, safeguarding against unintended data modifications during compatibility conversions, and optimizing resource management and concurrency patterns. These updates collectively contribute to a more reliable, predictable, and correct system behavior. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a substantial number of bug fixes across the codebase, enhancing stability and correctness. The changes address issues ranging from potential panics and race conditions to incorrect logic in data conversions and error handling. The fixes are well-implemented and include corresponding test updates.
I have one suggestion for improvement regarding context propagation in the compatibility layer to enhance observability, but overall, this is a solid set of fixes preparing for a more stable release.
* fix wrong allocation target size * terminate subscription after terminal event has been received * fix missing break after error * fix subscribing to a different taskID in case of work queue override * fix response not sent for methods not returning values * fix panic write attempt to unbuffered channel re #279
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v1.0.0-alpha.3...v1.0.0) (2026-03-17) ### Features * implement the new rest error handling ([#282](#282)) ([a3bda30](a3bda30)) * use v2 suffix for module ID and provide compat support ([#270](#270)) ([dd1b6ba](dd1b6ba)), closes [#250](#250) ### Bug Fixes * a2asrv jsonrpc Content-Type ([#265](#265)) ([2568a46](2568a46)) * bugs before going from alpha ([#279](#279)) ([b1f055c](b1f055c)) * GetTaskRequest nil pointer assignment check ([#258](#258)) ([440bb79](440bb79)) * inject headers into service params ([#277](#277)) ([d33f3bd](d33f3bd)), closes [#275](#275) * propagate cancelation signal using task store ([#272](#272)) ([5e1d462](5e1d462)), closes [#245](#245) * regenerate spec and fix returnImmediately ([#284](#284)) ([2eee0b9](2eee0b9)) * task modified after save ([#266](#266)) ([c15febe](c15febe)) * taskupdater result mutable ([#274](#274)) ([6038d92](6038d92)) * update pushsender ([#256](#256)) ([5f7a594](5f7a594)) * use enum values as in the spec ([#261](#261)) ([eb98981](eb98981)), closes [#251](#251) ### Documentation * **a2asrv:** add Example_* test functions for pkg.go.dev documentation ([#262](#262)) ([7888e37](7888e37)) * add example tests a2a ([#240](#240)) ([4fe08a9](4fe08a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).