Skip to content

fix: use enum values as in the spec#261

Merged
yarolegovich merged 5 commits intomainfrom
yarolegovich/fix-enums
Mar 9, 2026
Merged

fix: use enum values as in the spec#261
yarolegovich merged 5 commits intomainfrom
yarolegovich/fix-enums

Conversation

@yarolegovich
Copy link
Copy Markdown
Member

@yarolegovich yarolegovich commented Mar 8, 2026 •
edited
Loading

fixes #251

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 8, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the string representation of TaskState enum values by introducing a TASK_STATE_ prefix, ensuring consistency with an external specification. This change propagates through the codebase, updating all instances where these enum strings are used, particularly in JSON serialization/deserialization and test assertions. Additionally, the protobuf conversion logic for TaskState has been streamlined for better maintainability and includes improved test coverage.

Highlights

  • Enum Value Standardization: The string representations of TaskState enum values in a2a/core.go were updated to include the TASK_STATE_ prefix, aligning them with the specified format.
  • Test and Example Alignment: All corresponding test cases and example outputs across various files were adjusted to reflect the new TASK_STATE_ prefixed enum values, ensuring consistency.
  • Protobuf Conversion Refactoring: The conversion logic between a2a.TaskState and a2apb.TaskState in a2apb/v1/pbconv was refactored to use more concise map-based lookups, simplifying the code and improving maintainability.
  • Enhanced Test Coverage: New test coverage was added for the fromProtoTaskState conversion function to ensure correct mapping from protobuf enum integers to a2a.TaskState strings.
Changelog
  • a2a/core.go
    • Updated TaskState enum string values to include the TASK_STATE_ prefix.
  • a2a/event_json_test.go
    • Updated JSON test strings to use the new TASK_STATE_ prefixed enum values.
  • a2a/example_test.go
    • Adjusted expected output in examples to reflect the new TASK_STATE_ prefixed enum values.
  • a2a/json_test.go
    • Modified the stateToLabel map to align with the new TASK_STATE_ prefixed enum values.
  • a2aclient/jsonrpc_test.go
    • Updated JSON payload strings and assertion messages to use the new TASK_STATE_ prefixed enum values.
  • a2aclient/rest_test.go
    • Updated JSON response strings and assertion messages to use the new TASK_STATE_ prefixed enum values.
  • a2apb/v1/pbconv/from_proto.go
    • Refactored fromProtoTaskState function to use a map lookup for converting protobuf enum integers to a2a.TaskState strings.
  • a2apb/v1/pbconv/to_proto.go
    • Refactored toProtoTaskState function to use a map lookup for converting a2a.TaskState strings to protobuf enum integers.
  • a2apb/v1/pbconv/to_proto_test.go
    • Updated the "unknown" test case for toProtoTaskState to use the correct a2a.TaskStateUnknown constant.
    • Added a new assertion to verify the fromProtoTaskState conversion within the existing test.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the TaskState enum string values across the codebase to align with the specification. The refactoring in a2apb/v1/pbconv/from_proto.go and a2apb/v1/pbconv/to_proto.go to use the protoc-generated maps for enum conversion is a great improvement for maintainability.

I've identified a correctness issue in the new implementation of fromProtoTaskState which incorrectly handles the UNSPECIFIED state, as detailed in the specific comment. This comment has been retained as it highlights a valid bug that needs to be addressed.

@yarolegovich yarolegovich merged commit eb98981 into main Mar 9, 2026
4 checks passed
@yarolegovich yarolegovich deleted the yarolegovich/fix-enums branch March 9, 2026 07:47
@a2a-bot a2a-bot mentioned this pull request Mar 8, 2026
Merged
yarolegovich pushed a commit that referenced this pull request Mar 17, 2026
@a2a-bot
chore(main): release 1.0.0 (#252)
67b1354 
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](v1.0.0-alpha.3...v1.0.0)
(2026-03-17)


### Features

* implement the new rest error handling
([#282](#282))
([a3bda30](a3bda30))
* use v2 suffix for module ID and provide compat support
([#270](#270))
([dd1b6ba](dd1b6ba)),
closes [#250](#250)


### Bug Fixes

* a2asrv jsonrpc Content-Type
([#265](#265))
([2568a46](2568a46))
* bugs before going from alpha
([#279](#279))
([b1f055c](b1f055c))
* GetTaskRequest nil pointer assignment check
([#258](#258))
([440bb79](440bb79))
* inject headers into service params
([#277](#277))
([d33f3bd](d33f3bd)),
closes [#275](#275)
* propagate cancelation signal using task store
([#272](#272))
([5e1d462](5e1d462)),
closes [#245](#245)
* regenerate spec and fix returnImmediately
([#284](#284))
([2eee0b9](2eee0b9))
* task modified after save
([#266](#266))
([c15febe](c15febe))
* taskupdater result mutable
([#274](#274))
([6038d92](6038d92))
* update pushsender
([#256](#256))
([5f7a594](5f7a594))
* use enum values as in the spec
([#261](#261))
([eb98981](eb98981)),
closes [#251](#251)


### Documentation

* **a2asrv:** add Example_* test functions for pkg.go.dev documentation
([#262](#262))
([7888e37](7888e37))
* add example tests a2a
([#240](#240))
([4fe08a9](4fe08a9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enum values like Task State don't match the values in the specification

2 participants

@yarolegovich @darrelmiller