Skip to content

fix: GetTaskRequest nil pointer assignment check#258

Merged
yarolegovich merged 3 commits intoa2aproject:mainfrom
axkum10:axkum10-a2a-go-getRequest-historylen
Mar 8, 2026
Merged

fix: GetTaskRequest nil pointer assignment check#258
yarolegovich merged 3 commits intoa2aproject:mainfrom
axkum10:axkum10-a2a-go-getRequest-historylen

Conversation

@axkum10
Copy link
Copy Markdown
Contributor

@axkum10 axkum10 commented Mar 5, 2026

Added check for nil pointer. Mandatory check required to stop failure/crash if the history length is not provided.

axkum10 added 2 commits March 4, 2026 21:34
@axkum10
Update GetTaskRequest conversion logic, nil pointer check is mandator…
d8a18a0 
…y for requests that has not set historylen

Refactor GetTaskRequest conversion to conditionally set HistoryLength only if provided.
@axkum10
Refactor GetTaskRequest conversion logic
8fdce9e
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 5, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential runtime error in the ToProtoGetTaskRequest function by introducing a defensive nil check. It ensures that the HistoryLength field is only accessed and converted if it is not nil, thereby preventing application crashes when this optional field is absent.

Highlights

  • Nil Pointer Check: Implemented a nil pointer check for req.HistoryLength within the ToProtoGetTaskRequest function to prevent potential panics or crashes when HistoryLength is not provided.
Changelog
  • a2apb/v1/pbconv/to_proto.go
    • Added a nil check for req.HistoryLength before dereferencing it.
    • Refactored the GetTaskRequest proto creation to conditionally set the HistoryLength field.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a nil-pointer check for HistoryLength in ToProtoGetTaskRequest to prevent a potential panic. The review comment suggesting the addition of unit tests for this change, covering both nil and non-nil cases, is valid and has been retained.

@axkum10
Copy link
Copy Markdown
Contributor Author

axkum10 commented Mar 5, 2026

Hello,

Found this bug while testing an example program. the program errored out, because I did not set history length (optional field per specification). Looks like the function is not checking for nil pointer. Hence created this PR to fix the code.

@axkum10 axkum10 mentioned this pull request Mar 5, 2026
Closed
1 task
@axkum10 axkum10 changed the title Axkum10 a2a go get request historylen fix: GetTaskRequest nil pointer assignment check Mar 5, 2026
@yarolegovich
Copy link
Copy Markdown
Member

yarolegovich commented Mar 8, 2026

Thanks for the fix!

@yarolegovich yarolegovich merged commit 440bb79 into a2aproject:main Mar 8, 2026
4 checks passed
@a2a-bot a2a-bot mentioned this pull request Mar 8, 2026
Merged
yarolegovich pushed a commit that referenced this pull request Mar 17, 2026
@a2a-bot
chore(main): release 1.0.0 (#252)
67b1354 
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](v1.0.0-alpha.3...v1.0.0)
(2026-03-17)


### Features

* implement the new rest error handling
([#282](#282))
([a3bda30](a3bda30))
* use v2 suffix for module ID and provide compat support
([#270](#270))
([dd1b6ba](dd1b6ba)),
closes [#250](#250)


### Bug Fixes

* a2asrv jsonrpc Content-Type
([#265](#265))
([2568a46](2568a46))
* bugs before going from alpha
([#279](#279))
([b1f055c](b1f055c))
* GetTaskRequest nil pointer assignment check
([#258](#258))
([440bb79](440bb79))
* inject headers into service params
([#277](#277))
([d33f3bd](d33f3bd)),
closes [#275](#275)
* propagate cancelation signal using task store
([#272](#272))
([5e1d462](5e1d462)),
closes [#245](#245)
* regenerate spec and fix returnImmediately
([#284](#284))
([2eee0b9](2eee0b9))
* task modified after save
([#266](#266))
([c15febe](c15febe))
* taskupdater result mutable
([#274](#274))
([6038d92](6038d92))
* update pushsender
([#256](#256))
([5f7a594](5f7a594))
* use enum values as in the spec
([#261](#261))
([eb98981](eb98981)),
closes [#251](#251)


### Documentation

* **a2asrv:** add Example_* test functions for pkg.go.dev documentation
([#262](#262))
([7888e37](7888e37))
* add example tests a2a
([#240](#240))
([4fe08a9](4fe08a9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yarolegovich yarolegovich yarolegovich approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axkum10 @yarolegovich