feat: use v2 suffix for module ID and provide compat support#270
Merged
yarolegovich merged 10 commits intomainfrom Mar 9, 2026
Merged
feat: use v2 suffix for module ID and provide compat support#270yarolegovich merged 10 commits intomainfrom
yarolegovich merged 10 commits intomainfrom
Conversation
This reverts commit b964514.
herczyn
approved these changes
Mar 9, 2026
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a major version upgrade for the Go module, transitioning to a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a v2 of the module, updating the module path and providing a compatibility layer for v0.3 clients and servers. The changes are extensive, touching most of the codebase to update import paths and introduce conversion logic between new and legacy types. The addition of a migration layer with adapters for legacy components is a solid approach. Overall, the changes are well-structured. I've identified a critical bug in the JSON-RPC compatibility server that would cause incorrect responses, and a high-severity correctness issue in the task store adapter's error handling. Addressing these will be important for the stability of the compatibility layer.
Note: Security Review did not run due to the size of the PR.
Comment on lines
+212
to
+218
| version, err := s.TaskStore.Save(ctx, legacyTask, legacyEvent, legacya2a.TaskVersion(update.PrevVersion)) | ||
| if err != nil { | ||
| if errors.Is(err, legacya2a.ErrConcurrentTaskModification) { | ||
| return taskstore.TaskVersionMissing, taskstore.ErrConcurrentModification | ||
| } | ||
| } | ||
| return taskstore.TaskVersion(version), err |
Contributor
There was a problem hiding this comment.
When s.TaskStore.Save returns an error other than ErrConcurrentTaskModification, the function currently returns both the (potentially invalid) version and the error. It's better practice to return the zero value for TaskVersion (taskstore.TaskVersionMissing) whenever an error occurs to avoid ambiguity for the caller.
version, err := s.TaskStore.Save(ctx, legacyTask, legacyEvent, legacya2a.TaskVersion(update.PrevVersion))
if err != nil {
if errors.Is(err, legacya2a.ErrConcurrentTaskModification) {
return taskstore.TaskVersionMissing, taskstore.ErrConcurrentModification
}
return taskstore.TaskVersionMissing, err
}
return taskstore.TaskVersion(version), nilReferences
- Implement optimistic concurrency control in
Saveoperations by comparing the provided previous version with the currently stored version. If they don't match (and the previous version is notTaskVersionMissing), return an error to prevent race conditions. This comment ensures consistent error handling for version returns, aligning with robust version management.
yarolegovich
pushed a commit
that referenced
this pull request
Mar 17, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v1.0.0-alpha.3...v1.0.0) (2026-03-17) ### Features * implement the new rest error handling ([#282](#282)) ([a3bda30](a3bda30)) * use v2 suffix for module ID and provide compat support ([#270](#270)) ([dd1b6ba](dd1b6ba)), closes [#250](#250) ### Bug Fixes * a2asrv jsonrpc Content-Type ([#265](#265)) ([2568a46](2568a46)) * bugs before going from alpha ([#279](#279)) ([b1f055c](b1f055c)) * GetTaskRequest nil pointer assignment check ([#258](#258)) ([440bb79](440bb79)) * inject headers into service params ([#277](#277)) ([d33f3bd](d33f3bd)), closes [#275](#275) * propagate cancelation signal using task store ([#272](#272)) ([5e1d462](5e1d462)), closes [#245](#245) * regenerate spec and fix returnImmediately ([#284](#284)) ([2eee0b9](2eee0b9)) * task modified after save ([#266](#266)) ([c15febe](c15febe)) * taskupdater result mutable ([#274](#274)) ([6038d92](6038d92)) * update pushsender ([#256](#256)) ([5f7a594](5f7a594)) * use enum values as in the spec ([#261](#261)) ([eb98981](eb98981)), closes [#251](#251) ### Documentation * **a2asrv:** add Example_* test functions for pkg.go.dev documentation ([#262](#262)) ([7888e37](7888e37)) * add example tests a2a ([#240](#240)) ([4fe08a9](4fe08a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #250