[Mobile] - Block selection - Expand tapping on nested blocks directly#50672
Merged
[Mobile] - Block selection - Expand tapping on nested blocks directly#50672
Conversation
|
Size Change: -3.73 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
dcalhoun
approved these changes
May 17, 2023
Member
dcalhoun
left a comment
There was a problem hiding this comment.
A nice improvement for block selection to align more closely with the web editor. We should likely add a release note for this change. 🚀
4 tasks
dcalhoun
added a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Jun 28, 2023
This behavior was modified in WordPress/gutenberg#50672.
dcalhoun
added a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Jun 28, 2023
* docs: Remove broken reference to removed Columns test case This case was removed in 2356f5d. * docs: Update Groups test to mirror deepest-descendent-first approach This behavior was modified in WordPress/gutenberg#50672. * docs: Buttons radius interface uses stepper buttons * docs: Capture known color settings issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR enables tapping on nested blocks directly as a follow-up of previous code changes where it was enabled for text-based blocks.
Why?
To keep consistency with the web editor so both have the same behavior when tapping on blocks.
How?
By updating the
onFocuscode to use theclientIdinstead of looking for the first block to select depending on the nested level.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Before.mov
After.mov