Skip to content

[Mobile] - Block selection - Expand tapping on nested blocks directly#5781

Merged
geriux merged 13 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly
May 18, 2023
Merged

[Mobile] - Block selection - Expand tapping on nested blocks directly#5781
geriux merged 13 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly

Conversation

@wpmobilebot
Copy link
Copy Markdown
Collaborator

@wpmobilebot wpmobilebot commented May 16, 2023

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 16, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch from 51c60f2 to 2d14b43 Compare May 17, 2023 13:39
@geriux geriux self-assigned this May 17, 2023
@geriux geriux requested a review from dcalhoun May 17, 2023 15:15
@geriux geriux added this to the 1.96.0 (22.5) milestone May 17, 2023
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement for block selection to align more closely with the web editor. We should likely add a release note for this change. 🚀

Also, there are several other tests that rely upon "Navigate Up." Should leave them as-is or attempt to refactor them?

@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch from 2d14b43 to 2d2254f Compare May 18, 2023 11:00
Gerardo and others added 5 commits May 18, 2023 14:39
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Co-authored-by: David Calhoun <github@davidcalhoun.me>
…sted-blocks-directly' of github.com:wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly
@geriux geriux merged commit 5267a0f into trunk May 18, 2023
@geriux geriux deleted the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch May 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants