[Testing] - Block selection - Expand tapping on nested blocks directly by geriux · Pull Request #18448 · wordpress-mobile/WordPress-Android

geriux · 2023-05-17T14:25:39Z

Fixes #

To test:

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

peril-wordpress-mobile · 2023-05-17T14:25:44Z

	Fails
🚫	This PR is tagged with 'Do Not Merge' label.

Generated by 🚫 dangerJS

wpmobilebot · 2023-05-17T14:34:31Z

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.95.0
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
-          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
-          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
-          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
-          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
-          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
-          |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
-          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
-          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
-          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.95.0
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-          |    +--- org.wordpress:aztec:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.6.3
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
-          |    |    +--- org.wordpress:aztec:v1.6.3 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:5781-2d14b43a2dc669984d65bebc435e96c3a7a41a5c
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
+          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
+          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
+          |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
+          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
+          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
+          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:5781-2d14b43a2dc669984d65bebc435e96c3a7a41a5c
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+          |    +--- org.wordpress:aztec:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.6.3
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+          |    |    +--- org.wordpress:aztec:v1.6.3 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)

Please review and act accordingly

wpmobilebot · 2023-05-17T14:45:51Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18448-88a05f2
	Commit	`88a05f2`
	Direct Download	`jetpack-prototype-build-pr18448-88a05f2.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-05-17T14:45:57Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18448-88a05f2
	Commit	`88a05f2`
	Direct Download	`wordpress-prototype-build-pr18448-88a05f2.apk`

Note: Google Login is not supported on these builds.

Update Gutenberg ref

88a05f2

geriux added Gutenberg Editing and display of Gutenberg blocks. Do Not Merge labels May 17, 2023

This was referenced May 17, 2023

[Mobile] - Block selection - Expand tapping on nested blocks directly WordPress/gutenberg#50672

Merged

[Mobile] - Block selection - Expand tapping on nested blocks directly wordpress-mobile/gutenberg-mobile#5781

Merged

geriux closed this May 18, 2023

geriux deleted the gutenberg/test-expand-tapping-on-nested-blocks-directly branch June 18, 2024 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] - Block selection - Expand tapping on nested blocks directly#18448

[Testing] - Block selection - Expand tapping on nested blocks directly#18448
geriux wants to merge 1 commit intotrunkfrom
gutenberg/test-expand-tapping-on-nested-blocks-directly

geriux commented May 17, 2023

Uh oh!

peril-wordpress-mobile bot commented May 17, 2023

Uh oh!

wpmobilebot commented May 17, 2023

Uh oh!

wpmobilebot commented May 17, 2023

Uh oh!

wpmobilebot commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

geriux commented May 17, 2023

Regression Notes

Uh oh!

peril-wordpress-mobile bot commented May 17, 2023

Uh oh!

wpmobilebot commented May 17, 2023

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented May 17, 2023

Uh oh!

wpmobilebot commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants