Skip to content

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#39097

Closed
ParaskP7 wants to merge 30 commits intoWordPress:trunkfrom
ParaskP7:update/gradle-to-7.3.3-agp-to-7.0.4
Closed

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#39097
ParaskP7 wants to merge 30 commits intoWordPress:trunkfrom
ParaskP7:update/gradle-to-7.3.3-agp-to-7.0.4

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Feb 25, 2022

Related PR: #39508 (updated)

Description

This PR upgrades all react-native Android libraries to Gradle 7.4 & AGP 7.1.1.

It includes the following:

Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#4652
Related WordPress-Android PR: Upgrade Gradle to 7.4 & AGP to 7.1.1 #15865 (for manual testing purposes)

Testing Instructions

Manual testing of the react-native demo Editor and main WPAndroid app that include these changes.

Screenshots

N/A

Types of changes

Android build file changes for react-native projects & react-native library updates for Android projects.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 25, 2022
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ParaskP7! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

ParaskP7 added 2 commits March 1, 2022 15:13
After updating all node module forked libraries to
'Gradle 7.4 & AGP 7.1.1', this commit update the node module project
dependencies to point to that 'update/gradle-to-7.3.3-agp-to-7.0.4'
branch for all of them, which has this new version.

This is mainly done for testing purposes. Afterwards, and upon
verifying that everything is okay, all those draft node module forked
library PRs will get merged and a new node module forked library version
will be tagged and used in favor of these temporarily coordinates.
@ParaskP7 ParaskP7 force-pushed the update/gradle-to-7.3.3-agp-to-7.0.4 branch from 02bd78a to 347cd59 Compare March 1, 2022 14:22
ParaskP7 added 2 commits March 4, 2022 17:00
…dle-to-7.3.3-agp-to-7.0.4

� Conflicts:
�	package-lock.json
�	packages/react-native-editor/package.json
After updating all node module forked libraries to
'Gradle 7.4 & AGP 7.1.1', this commit update the node module project
dependencies to point to that 'update/gradle-to-7.3.3-agp-to-7.0.4'
branch for all of them, which has this new version.

This is mainly done for testing purposes. Afterwards, and upon
verifying that everything is okay, all those draft node module forked
library PRs will get merged and a new node module forked library version
will be tagged and used in favor of these temporarily coordinates.
ParaskP7 added 5 commits March 9, 2022 14:51
After updating all node module forked libraries to
'Gradle 7.4 & AGP 7.1.1', this commit update the node module project
dependencies to point to that 'update/gradle-to-7.3.3-agp-to-7.0.4'
branch for all of them, which has this new version.

This is mainly done for testing purposes. Afterwards, and upon
verifying that everything is okay, all those draft node module forked
library PRs will get merged and a new node module forked library version
will be tagged and used in favor of these temporarily coordinates.
After updating all node module forked libraries to
'Gradle 7.4 & AGP 7.1.1', this commit update the node module project
dependencies to point to that 'update/gradle-to-7.3.3-agp-to-7.0.4'
branch for all of them, which has this new version.

This is mainly done for testing purposes. Afterwards, and upon
verifying that everything is okay, all those draft node module forked
library PRs will get merged and a new node module forked library version
will be tagged and used in favor of these temporarily coordinates.
@fluiddot fluiddot added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Mar 14, 2022
@ParaskP7 ParaskP7 force-pushed the update/gradle-to-7.3.3-agp-to-7.0.4 branch from 3619e47 to 27d5519 Compare March 14, 2022 14:16
@fluiddot
Copy link
Copy Markdown
Contributor

@ParaskP7 I created the following branch rnmobile/try/gradle-to-7.3.3-agp-to-7.0.4 for testing these changes. As you can see in the changes, for fetching the Android artifacts, I'm using the version update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT, except for the package react-native-screens, which for some reason the artifact was published with the commit SHA 🤷‍♂️ .

In any case, I'm getting the following error when building:

Duplicate class com.swmansion.common.GestureHandlerStateManager found in modules react-native-gesture-handler-update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT-runtime (com.github.wordpress-mobile:react-native-gesture-handler:update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT:1bd872fcd9-1) and react-native-reanimated-update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT-runtime (com.github.wordpress-mobile:react-native-reanimated:update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT:1.9.0-g734d446-847)

This error is probably the same that I'm trying to fix in #39430 (comment). So, once I merge wordpress-mobile/react-native-gesture-handler#18, I'll update everything again.

@ParaskP7
Copy link
Copy Markdown
Contributor Author

👋 @fluiddot !

Thank you so much for the update and working on this! 🙇

@ParaskP7 I created the following branch rnmobile/try/gradle-to-7.3.3-agp-to-7.0.4 for testing these changes. As you can see in the changes, for fetching the Android artifacts, I'm using the version update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT, except for the package react-native-screens, which for some reason the artifact was published with the commit SHA 🤷‍♂️ .

👀

In any case, I'm getting the following error when building:

Duplicate class com.swmansion.common.GestureHandlerStateManager found in modules react-native-gesture-handler-update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT-runtime (com.github.wordpress-mobile:react-native-gesture-handler:update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT:1bd872fcd9-1) and react-native-reanimated-update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT-runtime (com.github.wordpress-mobile:react-native-reanimated:update~gradle-to-7.3.3-agp-to-7.0.4-SNAPSHOT:1.9.0-g734d446-847)

🤔

This error is probably the same that I'm trying to fix in #39430 (comment). So, once I merge wordpress-mobile/react-native-gesture-handler#18, I'll update everything again.

👍 🤞

@fluiddot
Copy link
Copy Markdown
Contributor

@ParaskP7 I finally merged the fix for react-native-gesture-handler, and now I'm able to build the demo app with branch rnmobile/try/gradle-to-7.3.3-agp-to-7.0.4. I'll try to spare some time today for smoke testing the changes 🤞 .

@ParaskP7
Copy link
Copy Markdown
Contributor Author

This draft PR is now closed in favor of the newest and more up-to-date #39508 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants