This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#11
Closed
Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#11
Conversation
oguzkocer
approved these changes
Feb 16, 2022
oguzkocer
approved these changes
Feb 16, 2022
|
I accidentally double approved this one 🤦 |
Author
That means I did a hell of a job then, kudos to me! 🤣 😛 😛 |
The 'com.dipien.byebyejetifier' plugin was used to determine whether Jetifier can be disable for this project. After configuring 'Bye Bye Jetifier' and running the below command: ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false The output was clear, Jetifier can be now safely disabled for this project: > Task :canISayByeByeJetifier ========================================= Project: : ========================================= * No legacy android support usages found ===================================================== ... * No dependencies with legacy android support usages! ... ===================================================== ... ... =============================== ... You can say Bye Bye Jetifier. * ... ===============================
24 tasks
Author
|
Since we removed the source code for these projects from PS: Eventually, we might upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier) PR. There are
13libraries that are upgraded toGradle 7.4&AGP 7.1.1(&Disable Jetifier).All those PRs follow the general outline below:
Gradleversion upgraded to7.3.3with the./gradlew wrapper --gradle-version=7.3.3 --distribution-type=allcommand.AGPversion upgrade to7.0.4(seeandroid/settings.gradle.ktschange).Gradle 7.4&AGP 7.1.1.android/gradle.propertieschange).3.0.2-wp-3(seepackage.json).3.0.2-wp-3(seereact-native-community-slider-3.0.2-wp-3.tgz).This PR also included the following changes:
openjdk11(seejitpack.ymlchange).To test - Now
These changes can be tested as part of the gutenberg PR which is updated to use the temporarily non-tagged node module project dependencies generated with these changes.
To test - Later ⚙️
These changes can be tested as part of the gutenberg-mobile PR ⚙️ or WordPress-Android PR ⚙️ which is updated to use the bundle ⚙️ generated with these changes.
FYI: It's best to leave the testing step to the gutenberg PR review since even if these PRs are merged, they won't impact anything until the package.json file is updated. Worst case scenario, a follow up PR will get opened to fix any issues that are found during testing.
Follow up
Once these PRs are merged in, a new tag will get created for each library and the package.json file will be again updated accordingly.