Skip to content

[RNMobile] Upgrade Gradle to 7.4 & AGP to 7.1.1#39508

Merged
fluiddot merged 14 commits intoWordPress:trunkfrom
ParaskP7:update/gradle-to-7.3.3-agp-to-7.0.4-v2
Mar 23, 2022
Merged

[RNMobile] Upgrade Gradle to 7.4 & AGP to 7.1.1#39508
fluiddot merged 14 commits intoWordPress:trunkfrom
ParaskP7:update/gradle-to-7.3.3-agp-to-7.0.4-v2

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 16, 2022 •
edited
Loading

Related PR: #39097 (outdated)

Description

This PR upgrades all react-native Android libraries to Gradle 7.4 & AGP 7.1.1.

It includes the following:

  • Gradle version upgraded to 7.3.3 with the ./gradlew wrapper --gradle-version=7.3.3 --distribution-type=all command.
  • AGP version upgrade to 7.0.4 (see android/settings.gradle.kts change).
  • Build output diff:
    • To identify and fix new warnings/errors that got added.
    • To identify and verify old warnings/errors that got removed.
  • Lint output diff
    • To identify and fix new warnings/errors that got added.
    • To identify and verify old warnings/errors that got removed.
  • The above 4 steps were redone with a follow-up update to Gradle 7.4 & AGP 7.1.1.
  • The above Gradle 7.4 & AGP 7.1.1 upgrade was done for the main 3 react-native libraries:
    • react-native-aztec
    • react-native-bridge
    • react-native-editor

Related gutenberg-mobile PR: Upgrade Gradle to 7.4 & AGP to 7.1.1 #4662
Related WordPress-Android PR: Upgrade Gradle to 7.4 & AGP to 7.1.1 #15865 (for manual testing purposes)

Testing Instructions

Manual testing of the react-native demo Editor and main WPAndroid app that include these changes.

Screenshots

N/A

Types of changes

Android build file changes for react-native projects & react-native library updates for Android projects.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

ParaskP7 added 13 commits March 16, 2022 17:10
@ParaskP7
Build: Update gradle to 7.3.3 for react native aztec project
cc55d08
@ParaskP7
Build: Update agp to 7.0.4 for react native aztec project
bdce19f
@ParaskP7
Build: Update gradle to 7.4 for react native aztec project
04b199a
@ParaskP7
Build: Update agp to 7.1.1 for react native aztec project
e58002b
@ParaskP7
Build: Update gradle to 7.3.3 for react native bridge project
5ad2881
@ParaskP7
Build: Update agp to 7.0.4 for react native bridge project
e7ed7f2
@ParaskP7
Build: Update gradle to 7.4 for react native bridge project
cf94910
@ParaskP7
Build: Update agp to 7.1.1 for react native bridge project
e3be5fa
@ParaskP7
Build: Update gradle to 7.3.3 for react native editor project
8d6d26a
@ParaskP7
Build: Update agp to 7.0.4 for react native editor project
a297b5e
@ParaskP7
Build: Update gradle to 7.4 for react native editor project
6926faf
@ParaskP7
Build: Update agp to 7.1.1 for react native editor project
0ec58e7
@ParaskP7
CI: Use desired version of java (11) to the android github action
5b86366
@ParaskP7 ParaskP7 mentioned this pull request Mar 16, 2022
Closed
24 tasks
@fluiddot fluiddot added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Mar 16, 2022
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 16, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ParaskP7! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@wpmobilebot wpmobilebot mentioned this pull request Mar 16, 2022
Merged
fluiddot
fluiddot reviewed Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParaskP7 I tested these changes with the demo app and, as far as I tested, everything is working as expected 🎊. Let me know if you plan to introduce any further changes and whether the PR is ready to be reviewed, thanks 🙇 .

UPDATE: All PR checks including the ones from wordpress-mobile/gutenberg-mobile#4662 are 🟢 🎊 .

@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Mar 17, 2022 •
edited
Loading

@ParaskP7 as the last check, it would be great if you could update the Gutenberg Mobile reference here in wordpress-mobile/WordPress-Android#15865, this way we could assure that WordPress-Android project is built without issues. We can reference a commit SHA of GB-mobile PR, in this case, you could use: 4662-822b36f4ae74c0a68ac37a0db442f7253889cc6b.

@ParaskP7 ParaskP7 marked this pull request as ready for review March 18, 2022 09:12
@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 18, 2022

👋 @fluiddot !

Thank you for the review and testing! 🎉 ❤️ 🚀

@ParaskP7 I tested these changes with the demo app and, as far as I tested, everything is working as expected 🎊.

This is great! 🥇

Let me know if you plan to introduce any further changes and whether the PR is ready to be reviewed, thanks 🙇 .

No, I don't plan to introduce any further changes, this PR is ready to be reviewed, I just flipped the PR to Ready for review! 💯

UPDATE: All PR checks including the ones from wordpress-mobile/gutenberg-mobile#4662 are 🟢 🎊 .

Awesome! 🥇

@ParaskP7 as the last check, it would be great if you could update the Gutenberg Mobile reference here in wordpress-mobile/WordPress-Android#15865, this way we could assure that WordPress-Android project is built without issues.

Let me do that and then test it. I'll let you know when that is done! 👍

We can reference a commit SHA of GB-mobile PR, in this case, you could use: 4662-822b36f4ae74c0a68ac37a0db442f7253889cc6b.

Great, got it, will do! 👍

fluiddot
fluiddot approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work @ParaskP7 🎊.

UPDATE: Before merging the PR, it would be great to check with wordpress-mobile/WordPress-Android#15865 PR that these changes work as expected in WordPress-Android.

@ParaskP7 ParaskP7 mentioned this pull request Mar 18, 2022
Merged
39 tasks
ParaskP7 added a commit to wordpress-mobile/WordPress-Android that referenced this pull request Mar 18, 2022
@ParaskP7
Build: Update gutenberg mobile hash
46cb24f 
This 'Gutenberg Mobile' hash updates 'Gutenberg Mobile' to that branch
version where 'Gradle & AGP' is also upgraded to version '7.4 & 7.1.1'
correspondingly.

This step is required in order to check that these 'Gutenberg' changes
work as expected with this WPAndroid client.

Gutenberg PR: WordPress/gutenberg#39508
@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 18, 2022 •
edited
Loading

LGTM! Awesome work @ParaskP7 🎊.

Awesome, back to you @fluiddot ! 🥇

UPDATE: Before merging the PR, it would be great to check with wordpress-mobile/WordPress-Android#15865 PR that these changes work as expected in WordPress-Android.

As per your recommendation, I just update Gutenberg on the corresponding WPAndroid PR.

Then, I tested that WPAndroid can be build and that everything works as expected. I tried to create a new Post, add a couple of blocks and then publish it. I am not sure if this basic smoke testing of mine if all that is needed, so do feel free to let me know what else I should be testing or pull the latest changes on this WPAndroid PR and try to test it yourself as well.

THANK YOU!!! 🎉 ❤️ 🚀

@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Mar 18, 2022

Then, I tested that WPAndroid can be build and that everything works as expected. I tried to create a new Post, add a couple of blocks and then publish it. I am not sure if this basic smoke testing of mine if all that is needed, so do feel free to let me know what else I should be testing or pull the latest changes on this WPAndroid PR and try to test it yourself as well.

Awesome, I think the tests you performed are enough for smoke testing. AFAIK the parts that could have been affected due to these changes are the build process and maybe the editor initialization. If you already covered that, I think we're safe to merge the PR.

However, I'd like to note that since we've just cut the GB-mobile version 1.72.0, we have to hold any change that we might want to include into the main apps (i.e. WordPress-Android and WordPress-iOS) until the release 19.5 of the main apps is done next Monday. This is a limitation we have in GB-mobile due to the release process, but as an alternative, if we need to merge native changes, we could merge them into the temporal gutenberg/after_1.72.0 on the main apps, which will be merged back to trunk after the release 19.5 is completed. In. case of your PR, probably it would make more sense to wait for next Monday/Tuesday to prevent potential conflicts, would it be possible?

@fluiddot fluiddot changed the title Upgrade Gradle to 7.4 & AGP to 7.1.1 [RNMobile] Upgrade Gradle to 7.4 & AGP to 7.1.1 Mar 23, 2022
@fluiddot fluiddot merged commit 558e4c3 into WordPress:trunk Mar 23, 2022
@github-actions github-actions bot added this to the Gutenberg 12.9 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 12.9

Development

Successfully merging this pull request may close these issues.

2 participants

@ParaskP7 @fluiddot