Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#10
Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#10
Conversation
oguzkocer
left a comment
There was a problem hiding this comment.
I am approving the PR to keep things moving, but the CI error seems to be new, so might be worth a look. I think the android build will still fail, but the error should be related to NDK (which is the issue we have in trunk) and not the software component. The more important thing is that Jitpack is able to build and publish the library without issues in which case the CI can be ignored. Hopefully these forks will be removed soon, so I don't suggest spending too much time on it.
|
👋 @oguzkocer !
Thanks for approving! 👍 I will definitely take a look at it as some point, it's on my list for later. It seems to be related to the example app, which is anyway outdated (
👍 🤔
👍 Btw, how were you able to verify that the
👍 |
|
👋 @oguzkocer !
Once more thanks for guiding me on this. 🥇 FYI: I just tried to do the same for the react-native-get-random-values node module fork library and it worked like a charm. 💎 Now I know. 🙇 |
The 'com.dipien.byebyejetifier' plugin was used to determine whether Jetifier can be disable for this project. After configuring 'Bye Bye Jetifier' and running the below command: ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false The output was clear, Jetifier can be now safely disabled for this project: > Task :canISayByeByeJetifier ========================================= Project: : ========================================= * No legacy android support usages found ===================================================== ... * No dependencies with legacy android support usages! ... ===================================================== ... ... =============================== ... You can say Bye Bye Jetifier. * ... ===============================
|
Closing this PR as the repository will be archived (more info in #11), so, no need for further work on it. Thank you for the hard work on this far folks! ❤️ |
This PR is part of Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier) PR. There are
13libraries that are upgraded toGradle 7.4&AGP 7.1.1(&Disable Jetifier).All those PRs follow the general outline below:
Gradleversion upgraded to7.3.3with the./gradlew wrapper --gradle-version=7.3.3 --distribution-type=allcommand.AGPversion upgrade to7.0.4(seeandroid/settings.gradle.ktschange).Gradle 7.4&AGP 7.1.1.android/gradle.propertieschange).3.2.0-wp-3(seepackage.json).3.2.0-wp-3(seereact-native-safe-area-context-3.2.0-wp-3.tgz).FYI: There exist an android-build job that fails, but this relates to the Android example app project, which is knowingly and explicitly ignored as we are not interested in updating this project at this point.
To test - Now
These changes can be tested as part of the gutenberg PR which is updated to use the temporarily non-tagged node module project dependencies generated with these changes.
To test - Later ⚙️
These changes can be tested as part of the gutenberg-mobile PR ⚙️ or WordPress-Android PR ⚙️ which is updated to use the bundle ⚙️ generated with these changes.
FYI: It's best to leave the testing step to the gutenberg PR review since even if these PRs are merged, they won't impact anything until the package.json file is updated. Worst case scenario, a follow up PR will get opened to fix any issues that are found during testing.
Follow up
Once these PRs are merged in, a new tag will get created for each library and the package.json file will be again updated accordingly.