readCapytaine_bugFixes_for_bemio_not_reading_multibody_runs_hydrostatics_and_normalization #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding dev and master build status to README
* Update tutorials to fix OSWEC inertia * Update terminology.rst * Update tutorials.rst changed OSWEC Iyy and added note Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
…h | Add 2021b to MATLAB versions (#862) * Split docs CI into test and build jobs This PR splits the docs CI workflow into two independent jobs. The first "test" job checks the current branch with any warnings triggering a failure. The second jobs builds and deploys the production docs, allowing any warnings to pass. This allows the commit author to see any new issues they may be adding to the docs while not stopping the docs being published. * Try to get color output in log * Remove redundant steps for branch test * Fix duplicate targets using anonymous references * Cancel previous runs if new commits are made * Fix spelling mistake to test concurrency * Limit concurrency to pull requests for the unit tests This is to ensure all commits on the master and dev branches are tested, which will be important if we are going to measure coverage using an external service like codecov. * Fix another spelling mistake * Add R2021b to explicit MATLAB versions tested
* Moved simulationClass.outputDir to public. * Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator. * Update line 38 in reaadAQWA.m so it works on a Mac. * change filesep in BEMIO examples, update readAQWA fileparts * Update stopWecSim.m Replaced hardcoded 'output' string with simu.outputDir. * Removed clc and close all from initializeWecSim. It should be up to the user to clear the command windows and close the figures. Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com> Co-authored-by: akeeste <akeeste@sandia.gov>
* Update stopWecSim.m * Update initializeWecSim.m * Update wecSimPCT.m
* update to v5.0 citation * moving citation page to release notes * adding some news articles Co-authored-by: kmruehl <kmruehl@sandia.gov>
* fix cable implementation * z-elv in nl hydro calc * adding cable library
dav-og
reviewed
Aug 31, 2022
| fileID = fopen(fullfile(meshdir,'Hydrostatics.dat')); | ||
| else | ||
| fileID = fopen([fullfile(meshdir,'Hydrostatics_'),num2str(m-1),'.dat']); | ||
| fileID = fopen([fullfile(meshdir,'Hydrostatics_'),num2str(m),'.dat']); |
Contributor
There was a problem hiding this comment.
I think this should be left as m-1 to keep with existing convention of starting from KH_0.dat, Hydrostatics_0.dat, etc
dav-og
reviewed
Aug 31, 2022
| fileID = fopen(fullfile(meshdir,'KH.dat')); | ||
| else | ||
| fileID = fopen([fullfile(meshdir,'KH_'),num2str(m-1),'.dat']); | ||
| fileID = fopen([fullfile(meshdir,'KH_'),num2str(m),'.dat']); |
Contributor
There was a problem hiding this comment.
I think this should be left as m-1 to keep with existing convention of starting from KH_0.dat, Hydrostatics_0.dat, etc
Contributor
Author
|
@dav-og |
Contributor
Author
|
I will be putting in this pull request again to avoid conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug fixes,