New pto sim lib #821
Merged
New pto sim lib #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Read_AQWA Testing FIles Troubleshoot effort * Fix added mass reading * Update RM3 AQWA Example * renaming directory to RM3 for consistancy Co-authored-by: kmruehl <kmruehl@sandia.gov>
* Update wecSimInputFile.m Insert descriptive text so people reading the commit history can quickly identified what files were changed. * Update Normalize.m to have correct sorting of the mean drift force coefficients. * Update Normalize.m There are three other instances where the function exist was replaced with isfield. * Update Read_NEMOH.m With changes to Normalize the mean drift forces from NEMOH were being normalized by rho and g twice. For consistency with using the normalize.m function removing the normalization from Read_NEMOH.m. * Update wecSimInputFile.com Not sure why this was changed, but reverting back to the example wecSimInputFile.m in hopes of eliminating this change.
Collaborator
Collaborator
kmruehl
requested changes
Mar 14, 2022
Collaborator
There was a problem hiding this comment.
@jleonqu this is looking good and I think we should prioritize merging it and opening another PR for further revisions.
These revisions should be made prior to merge:
- Please delete this file:
source/lib/PTO-Sim/BlockFigures/PTOSim_Lib.slx - This file should not be empty, please revert:
source/objects/ptoClass.m
Contributor
Author
|
@kmruehl I am not sure about the second comment "This file should not be empty, please revert: source/objects/ptoClass.m", this is the file I currently have in the PR: ptoClass.m |
Collaborator
|
That's strange, this is what the review is showing on my end: Nothing should have been updated in the |
Collaborator
|
@jleonqu I'd like to merge this into dev but now there are some merge conflicts, can you resolve them? |
Contributor
Author
|
@kmruehl I have resolved the conflicts |
Pto sim revised names
kmruehl
approved these changes
Mar 16, 2022
H0R5E
added a commit
to H0R5E/WEC-Sim
that referenced
this pull request
Mar 17, 2022
* Update Read_AQWA (WEC-Sim#761) * Update Read_AQWA Testing FIles Troubleshoot effort * Fix added mass reading * Update RM3 AQWA Example * renaming directory to RM3 for consistancy Co-authored-by: kmruehl <kmruehl@sandia.gov> * bugfix updating RM3 AQWA directory in test * Update to normalize to handle sorting mean drift forces (WEC-Sim#808) * Update wecSimInputFile.m Insert descriptive text so people reading the commit history can quickly identified what files were changed. * Update Normalize.m to have correct sorting of the mean drift force coefficients. * Update Normalize.m There are three other instances where the function exist was replaced with isfield. * Update Read_NEMOH.m With changes to Normalize the mean drift forces from NEMOH were being normalized by rho and g twice. For consistency with using the normalize.m function removing the normalization from Read_NEMOH.m. * Update wecSimInputFile.com Not sure why this was changed, but reverting back to the example wecSimInputFile.m in hopes of eliminating this change. * Add workflow for triggering WEC-Sim_Applications CI * Solving conflict with pots processing script * Solve conflicts * Excluding files that were not change in the PR * Revisions prior to merge * Revised names for PTO-Sim variables Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: kmruehl <kmruehl@sandia.gov> Co-authored-by: nathanmtom <nathan.tom@nrel.gov> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to solve some conflicts in the previous PR #743