Update Read_AQWA #761
Update Read_AQWA #761
Conversation
Testing FIles Troubleshoot effort
|
I also updated the script to fix a bug that derives from my last PR for Read_AQWA. The added_mass was being overwritten with zeros the way I initially wrote the code so this commit fixes the added_mass readings. |
|
Can you please upload updated github zip |
|
Error using wecSim (line 46) |
|
@Devsh93 It seems like you had some issues with the RM3 AQWA example? I updated the AH1 and LIS files as I realized they weren't from my latest run -- thanks for catching it! For some reason, it won't let me upload a .zip file here, but let me know if you still need it and I can find a different way to upload. |
|
@jtgrasb this PR resolves issues with the READ_AQWA script, so I'd like to merge that. However, the RM3 AQWA BEM solution for looks like it has an irregular frequency issue that's causing IRF instabilities. Have you compared this AQWA solution to the other RM3 runs? Did you run this case with an internal lid?
|
|
@jtgrasb I'm going to merge this, but will reference this AQWA RM3 comment in another issue/pr |
|
@jtgrasb would you like to delete this branch? |
|
@kmruehl Thanks! I deleted it and I will address the RM3 issue in the other PR. |
* Update Read_AQWA (#761) * Update Read_AQWA Testing FIles Troubleshoot effort * Fix added mass reading * Update RM3 AQWA Example * renaming directory to RM3 for consistancy Co-authored-by: kmruehl <kmruehl@sandia.gov> * bugfix updating RM3 AQWA directory in test * Update to normalize to handle sorting mean drift forces (#808) * Update wecSimInputFile.m Insert descriptive text so people reading the commit history can quickly identified what files were changed. * Update Normalize.m to have correct sorting of the mean drift force coefficients. * Update Normalize.m There are three other instances where the function exist was replaced with isfield. * Update Read_NEMOH.m With changes to Normalize the mean drift forces from NEMOH were being normalized by rho and g twice. For consistency with using the normalize.m function removing the normalization from Read_NEMOH.m. * Update wecSimInputFile.com Not sure why this was changed, but reverting back to the example wecSimInputFile.m in hopes of eliminating this change. * Add workflow for triggering WEC-Sim_Applications CI * Solving conflict with pots processing script * Solve conflicts * Excluding files that were not change in the PR * Revisions prior to merge * Revised names for PTO-Sim variables Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: kmruehl <kmruehl@sandia.gov> Co-authored-by: nathanmtom <nathan.tom@nrel.gov> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
* Update Read_AQWA (WEC-Sim#761) * Update Read_AQWA Testing FIles Troubleshoot effort * Fix added mass reading * Update RM3 AQWA Example * renaming directory to RM3 for consistancy Co-authored-by: kmruehl <kmruehl@sandia.gov> * bugfix updating RM3 AQWA directory in test * Update to normalize to handle sorting mean drift forces (WEC-Sim#808) * Update wecSimInputFile.m Insert descriptive text so people reading the commit history can quickly identified what files were changed. * Update Normalize.m to have correct sorting of the mean drift force coefficients. * Update Normalize.m There are three other instances where the function exist was replaced with isfield. * Update Read_NEMOH.m With changes to Normalize the mean drift forces from NEMOH were being normalized by rho and g twice. For consistency with using the normalize.m function removing the normalization from Read_NEMOH.m. * Update wecSimInputFile.com Not sure why this was changed, but reverting back to the example wecSimInputFile.m in hopes of eliminating this change. * Add workflow for triggering WEC-Sim_Applications CI * Solving conflict with pots processing script * Solve conflicts * Excluding files that were not change in the PR * Revisions prior to merge * Revised names for PTO-Sim variables Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: kmruehl <kmruehl@sandia.gov> Co-authored-by: nathanmtom <nathan.tom@nrel.gov> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk>
I altered the Read_AQWA function so that it can account for headers in the LIS file (resolves issue #683). AQWA places the headers in different places for the Froude-Krylov and Diffraction Forces depending on the amount of frequencies being run. The updated Read_AQWA function keeps a count of when a header is placed in order to skip the header and only read in the relevant data.