DRAFT: Updated blocks: Gas Hydraulic Accumulator, compressible fluid piston,… #743
Conversation
… and electric machine
|
The PTO-sim updates look pretty good so far! I am not very familiar with the details of PTO systems so I have a few questions: |
dav-og
left a comment
There was a problem hiding this comment.
nice work Jorge! - the new additions look good - although I haven't tested them in an example case. I did check the PR with another model that features a heavily modified incompressible fluid piston block, accumulators, motor, valves, etc and everything is working fine 👍
if you have a working example using the new blocks that could be a nice test to include - lets discuss with the others, re: https://github.com/WEC-Sim/WEC-Sim/projects/58#card-64155595
|
Thanks David and Jeff for your comments. I have included more hydraulic blocks and there is an application example in examples/RM3NewPTOSim. Jeff, the electric machine block can be used to simulated an electric generator. It could be used to simulate an electric motor with some minor modifications. There some options for hydraulic accumulators such as a spring load accumulator or a gas charged accumulator, in this case I have decided to start with the gas charged accumulator. |
|
Looks good Jorge - seems to be working fine 👍 |
|
I am getting a few errors when trying to run the example case. First, the PTOSimBlock variable is spelled incorrectly in the wecSimInputFile. Once I fixed this, I was still getting the following errors, which I couldn't figure out how to fix.
I also noticed that some of the variables are not in camel case, such as some variables in PTOSimClassUpdated.m (Ex: BulkModulus should be changed to bulkModulus to be consistent with WEC-Sim convention). |
…draulic motor with variant subsystem
docs/user/code_structure.rst
Outdated
| initialized in the ``wecSimInputFile.m`` script. There are three properties that must be initialized for all the PTO-Sim blocks, | ||
| those are the name, the block number, and the type:: | ||
|
|
||
| PTOSimBlock(i) = cableClass('PTOsimName'); |
There was a problem hiding this comment.
@jleonqu I believe cableClass should be ptoSimClass, but can you confirm and update as required.
| @@ -0,0 +1,11 @@ | |||
| # PTO-Sim Compressible Hydraulic PTO | |||
|
|
|||
| **Author:** Ratanak So | |||
There was a problem hiding this comment.
@jleonqu Minor comment, but I would expect you should be listed as an additional Author of this example or repository.
|
|
||
| **Author:** Ratanak So | ||
|
|
||
| **Version:** WEC-Sim v2.0 |
There was a problem hiding this comment.
@jleonqu You will need to update the WEC-Sim version number that this updated example will be compatible with.
|
|
||
| %Hydraulic Cylinder | ||
| %PTOSimBlcock(1) = PTOSimClassUpdated('HydraulicPiston'); | ||
| PTOSimBlock(1) = PTOSimClassUpdated('PTOSim1'); |
There was a problem hiding this comment.
@jleonqu can you double check if other changes need to be made to the code now that PTOSimClassUpdated was removed from this PR.
| TorqueHM = PTOSimBlock5_out.signals.values(:,2); | ||
| Current = PTOSimBlock6_out.i.Data; | ||
| Voltage = PTOSimBlock6_out.Voltage.Data; | ||
|
|
There was a problem hiding this comment.
@jleonqu Just for clarification, but the numeric values after PTOSimBlock_#_ will not be automatically updated and in this example these PTOSimBlocks are the corresponding blocks for the power conversion process. If so you may want to clarify as comments that if changes are made to this powerPlotCode.m the user will need to update these manually.
|
@jleonqu In the Some other minor notes:
@jleonqu If you are able to review and make some of these requested changes, I should be able to continue my review. |
|
Closing this PR. The updates are now in PR #821 |
This is a pull request with some PTO-Sim blocks updated.