Updates to the morisonElement and nlHydro Implementation #692
Conversation
Pulling Dev into Nathan's Branch
Updates to the WECSim_Lib.slx to set the morisonElement and NLHydro options per body rather than globally.
…onElement and nlHydro
Requires changing from simu class to body class.
|
@akeeste I was hoping you could check if I edited the |
|
@nathanmtom Yes I can check the masks and callbacks to ensure everything is working. I should get to it today or tomorrow. |
After running the WEC-Sim Applications Test File, the results of the test showed that additional changes needed to be made to the initialization file and the library to address changes with PR #692
Resolving issues with the WECSim_Applications GBM example.
akeeste
left a comment
There was a problem hiding this comment.
@nathanmtom
Can you grant me push access to your repo? I have a few updates to make the Run from Simulink feature work robustly. Otherwise I can put a PR into your branch from mine.
|
@akeeste Thanks for the review, I believe I have opened editing permission to my repo. If you still are having issues, then the pull request option would be fine. |
|
@nathanmtom Thanks! I was able to update your branch now. I added two commits that update the body mask callbacks to ensure the correct Morison Element parameters are visible depending on the chosen morisonElement.option and remove the old simu.morisonElement flag from the global reference frame. Everything looks good on the Run From Simulink side of things! Lastly, in a different PR I'm working on a developer manual addition about the callbacks and masks for Run From Simulink functionality. This will be aimed at helping the development team understand and change these features. I think you're the first to give it an attempt so if you have any feedback on what was difficult/confusing I'm happy to hear it. |
kmruehl
left a comment
There was a problem hiding this comment.
I've reviewed this as well, all tests on wec-sim and wec-sim_applications pass for me too. However we need to make a minor update to the WEC-Sim_Applications\Free_Decay\1m-ME example
|
@nathanmtom thank so much this is a huge improvement to the way WEC-Sim handles non-linear hydro and morison elements, thank you! |
|
@kmruehl I've just added you as a collaborator to my WEC-Sim Applications branch, but also if you let me know the update needed to be made happy to implement that since I thought I had double checked all application cases ran. |
* allow 0 hydro bodies and allow nonhydro to have fixed or eq mass value * add error checks for nonhydro cg and dispVol * update documentation on nonhydro bodies and traditional ME * fix wamit volume for bottom-fixed bodies * clarify required wave properties with 0 hydro bodies * resolving docs and initialize WecSim issues * updating for compatibility with #692 Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
Originally WEC-Sim would activate the morisonElement and nlHydro as a global variable across all bodies. This update allows the user to select individual bodies and activate the morisonElement or nlHydro options for that body. This should help improve computational time for bodies that do not have active elements.
To Do: