Skip to content

Allow zero hydro bodies resolves issue #655 #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akeeste merged 9 commits into from
Sep 15, 2021
Merged

Allow zero hydro bodies resolves issue #655 #691

akeeste merged 9 commits into from
Sep 15, 2021

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Aug 30, 2021 •
edited
Loading

This PR updates the body logic in WEC-Sim preprocessing to allow for zero hydro bodies. This condition is required if a user wants to run a case that only contains traditional Morison Elements.

If no hydro body is used (and therefore no .h5 file is read), users must define the waves.freqRange and waves.waterDepth variables. As with the current dev branch, users must define the cg and displace volume of drag/nonhydro bodies in the input file. Checks for these conditions are updated.

This resolves issue #655

@akeeste akeeste added the Drag/Morison related to drag body (body(i).nhBody = 2) or morison element (simu.morisonElement) label Aug 30, 2021
@kmruehl kmruehl self-requested a review August 30, 2021 21:40
@kmruehl
Copy link
Collaborator

kmruehl commented Aug 30, 2021

@akeeste do you have an example to test this with? It could be added to the https://github.com/WEC-Sim/WEC-Sim_Applications repository.

@akeeste
Copy link
Contributor Author

akeeste commented Aug 30, 2021

@kmruehl My seedling would be relevant, but that is several months away from becoming an application case. I could make a simplified example. Also I admit I still need to go through the documentation to update any comments requiring 1+ hydro body. I'll make this a draft PR until that is done.

@akeeste akeeste marked this pull request as draft August 30, 2021 22:46
@kmruehl kmruehl removed their request for review August 30, 2021 23:02
@akeeste akeeste marked this pull request as ready for review August 31, 2021 23:00
@akeeste
Copy link
Contributor Author

akeeste commented Aug 31, 2021 •
edited
Loading

This PR is now ready for review. I have updated the documentation to reflect that hydro bodies are no longer required for WEC-Sim to run (though at least one type of body is, regardless of type). Application repo PR #11 contains an application case comparing a traditional Morison Element (no hydro bodies) to a WEC-Sim hydrodynamic body.

I also made a minor change to the Read_WAMIT script to fix the displaced volume in cases of a bottom-fixed body.

@akeeste akeeste mentioned this pull request Aug 31, 2021
Merged
@kmruehl kmruehl self-requested a review September 8, 2021 14:21
@akeeste akeeste linked an issue Sep 15, 2021 that may be closed by this pull request
[Developer Issue] Hydro body logic and traditional morison element #655
Closed
@kmruehl kmruehl changed the title Allow zero hydro bodies Allow zero hydro bodies resolves issue #655 Sep 15, 2021
kmruehl
kmruehl requested changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be updated based on already merged PR for non-linear hydro and morison elements here: #692. I've marked the places this needs to be updated but may have missed a few.

@kmruehl kmruehl self-requested a review September 15, 2021 19:31
kmruehl
kmruehl approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akeeste this should be ready for a merge, but you may want to review it one more time before I merge it.

@akeeste
Copy link
Contributor Author

akeeste commented Sep 15, 2021

@kmruehl Thanks for updating this! I just reviewed one more time and things look good

@akeeste akeeste merged commit 42f6a94 into WEC-Sim:dev Sep 15, 2021
@akeeste akeeste deleted the nhBody_logic branch September 15, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmruehl kmruehl kmruehl approved these changes

Assignees

No one assigned

Labels

Drag/Morison related to drag body (body(i).nhBody = 2) or morison element (simu.morisonElement)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Developer Issue] Hydro body logic and traditional morison element

2 participants

@akeeste @kmruehl