Skip to content

Conversation

@MShabara
Copy link
Contributor

@MShabara MShabara commented Nov 1, 2024

No description provided.

@MShabara MShabara requested a review from akeeste November 1, 2024 20:20
@MShabara MShabara added the Bug bug in WEC-Sim source, high priority label Nov 1, 2024
@akeeste
Copy link
Contributor

akeeste commented Nov 4, 2024

@MShabara I fixed the library bug. I can't push directly to your PR for some reason so I made a PR into your branch: https://github.com/MShabara/WEC-Sim/pull/1. Once merging that PR, we can merge here.

Fix variable hydro data in QTF block
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MShabara. Merging

@akeeste akeeste merged commit 91cced3 into WEC-Sim:main Nov 4, 2024
@MShabara MShabara self-assigned this Nov 4, 2024
akeeste added a commit that referenced this pull request Nov 4, 2024
* Fixing documentation inconsistency for PTO-Sim blocks (#1330)

* Fixing documentation inconsistency for PTO-Sim blocks

* Adding comments to nondimensional values for clarification

* update analytics implementation in docs re deprecation of analytics_id (#1342)

* Body block library update for bug fix #1346  (#1347)

* fix on pDis function call

* preliminary fix for issue #1288

* Update readAQWA.m (#1253)

* body mask fixes for #1346

* add warning when variable hydro turned on for drag or nonhydro bodies

* flex body - add missing mask lines, define h5 button callback

---------

Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com>
Co-authored-by: akeeste <akeeste@sandia.gov>

* BIMIO to read NEMO QTF output files and do plots

* Fixes the plotQTF function when multiple hydro strctures are i/p

* Makes the body indecies start from 0 not from 1 to match the rest of NEMOH-BIMIO inputs for multibodies

* Fixes the bug in the bodyClass for the QTFs and variable hydro (#1351)

* fixes the bug in the bodyClass for the QTFs and variable hydro

* fix QTF block issue - dont make it an atomic systme

---------

Co-authored-by: akeeste <akeeste@sandia.gov>

* Update source/functions/BEMIO/QTFs/triToFullMatrix.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update source/functions/BEMIO/QTFs/triToFullMatrix.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update wecSimTest.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update source/functions/BEMIO/QTFs/triToFullMatrix.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update source/functions/BEMIO/plotBEMIO.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update source/functions/BEMIO/QTFs/plotQTFs.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

* Update source/functions/BEMIO/QTFs/plotQTFs.m

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>

---------

Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: dforbush2 <dforbus@sandia.gov>
Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com>
Co-authored-by: akeeste <akeeste@sandia.gov>
@akeeste akeeste mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants