WEC-Sim QTFs compatability with NEMOH #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing documentation inconsistency for PTO-Sim blocks * Adding comments to nondimensional values for clarification
* fix on pDis function call * preliminary fix for issue #1288 * Update readAQWA.m (#1253) * body mask fixes for #1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
…NEMOH-BIMIO inputs for multibodies
akeeste
requested changes
Nov 4, 2024
Contributor
akeeste
left a comment
There was a problem hiding this comment.
Thanks @MShabara. I have a few questions and suggestions on this PR before merging, summarized here:
- revert the default test behavior to running all tests
- updates to plotBEMIO and plotQTFs: these changes will make plotQTFs more robust. In my testing they worked for inputs
plotBEMIO(hydro1),plotQTFs(hydro1),plotBEMIO(hydro1, hydro2),plotQTFs(hydro1, hydro2) - Confirm that changes to
assignIDs, andtriToFullMatrixstill function with readWAMIT - suggestion to make column indexing more robust in
triToFullMatrix
* fixes the bug in the bodyClass for the QTFs and variable hydro * fix QTF block issue - dont make it an atomic systme --------- Co-authored-by: akeeste <akeeste@sandia.gov>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Contributor
Author
|
Hi @akeeste I responded to your question, and approved all the commits suggested. Please take a look and let me know what you think. |
Contributor
|
Thanks @MShabara. The tests are passing again, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the three QTF features:
1- Reading the NEMOH QTF outputs to BIMIO.
2- Does the contour plots of the mod of the sum and diff.
3- Adds a BIMIO/NEMOH example for a FOWT subjected to QTFs.
With this update WEC-Sim should be able to compute the second order forces based on the NEMOH outputs.