Body block library update for bug fix #1346 #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This also will need to go to the dev branch of WEC-Sim/WEC-Sim |
akeeste
approved these changes
Oct 30, 2024
Contributor
akeeste
left a comment
There was a problem hiding this comment.
Thanks @dforbush2. One addition:
- also added the missing mask lines to the Flex body
And a couple other things:
- added a warning if variable hydro is turned on with a nonhydro or drag body
- The flex body mask was missing the h5 button callback for WEC-Sim GUI functionality. I added it in (unrelated to this PR but a library issue worth fixing at the same time)
My gut says that we should merge this into main, merge #1328/#1332, then pull this into dev manually while it's fresh in our minds.
Contributor
|
Assuming the tests pass again, let's merge |
akeeste
added a commit
that referenced
this pull request
Nov 4, 2024
* Fixing documentation inconsistency for PTO-Sim blocks (#1330) * Fixing documentation inconsistency for PTO-Sim blocks * Adding comments to nondimensional values for clarification * update analytics implementation in docs re deprecation of analytics_id (#1342) * Body block library update for bug fix #1346 (#1347) * fix on pDis function call * preliminary fix for issue #1288 * Update readAQWA.m (#1253) * body mask fixes for #1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov> * BIMIO to read NEMO QTF output files and do plots * Fixes the plotQTF function when multiple hydro strctures are i/p * Makes the body indecies start from 0 not from 1 to match the rest of NEMOH-BIMIO inputs for multibodies * Fixes the bug in the bodyClass for the QTFs and variable hydro (#1351) * fixes the bug in the bodyClass for the QTFs and variable hydro * fix QTF block issue - dont make it an atomic systme --------- Co-authored-by: akeeste <akeeste@sandia.gov> * Update source/functions/BEMIO/QTFs/triToFullMatrix.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/QTFs/triToFullMatrix.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update wecSimTest.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/QTFs/triToFullMatrix.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/plotBEMIO.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/QTFs/plotQTFs.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/QTFs/plotQTFs.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> --------- Co-authored-by: Jorge Leon <72461917+jleonqu@users.noreply.github.com> Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> Co-authored-by: dforbush2 <dforbus@sandia.gov> Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the bug found in #1346 by updating the hydrodynamic body mask to propagate body number to the "From" flag in the radiation convolution integral calculation.
Credit to @hachikoi1 for finding this bug.