Skip to content

Conversation

@dforbush2
Copy link
Contributor

This is the equivalent of PR #1347 but made to the development branch. Credit to @hachikoi1 for finding the bug.

jleonqu and others added 4 commits October 5, 2024 11:30
* Fixing documentation inconsistency for PTO-Sim blocks

* Adding comments to nondimensional values for clarification
* fix on pDis function call

* preliminary fix for issue WEC-Sim#1288

* Update readAQWA.m (WEC-Sim#1253)

* body mask fixes for WEC-Sim#1346

* add warning when variable hydro turned on for drag or nonhydro bodies

* flex body - add missing mask lines, define h5 button callback

---------

Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com>
Co-authored-by: akeeste <akeeste@sandia.gov>
@dforbush2 dforbush2 requested a review from akeeste October 31, 2024 16:49
@dforbush2 dforbush2 self-assigned this Oct 31, 2024
@dforbush2 dforbush2 marked this pull request as draft October 31, 2024 16:49
@kmruehl kmruehl added the Bug bug in WEC-Sim source, high priority label Oct 31, 2024
@kmruehl
Copy link
Collaborator

kmruehl commented Oct 31, 2024

Thank you @dforbush2

@dforbush2 dforbush2 marked this pull request as ready for review October 31, 2024 16:58
@dforbush2
Copy link
Contributor Author

@akeeste please ensure the GUI h5 button callback is functioning as intended: I believe this already existed on dev branch but difficult to confirm against #1347

@kmruehl kmruehl assigned akeeste and unassigned dforbush2 Oct 31, 2024
@akeeste
Copy link
Contributor

akeeste commented Nov 1, 2024

I'll review this next week and may supercede it with a likely library fix needed in #1351

@dforbush2
Copy link
Contributor Author

This PR now also adds hydro.gbm field creation as appropriate to readCapytaine. Revert commit 0abf01c to remove this if desired.

This makes gbm modes specified in capytaine run out-of-the-box in wecSim, parallel functionality to what exists in readWAMIT with the following exception:

Capytaine does not at this time allow the specification of non-zero mechanical inertia, mechanical damping, and mechanical stiffness in the BEM run itself. These fields, (hydro.gbm(:,:,[1:3], respectively) are all set to zero, but the last element hydro.gbm(:,:,4) is the hydrostatic stiffness which is calculated. This may need to be changed in a future capytaine update, and throws a warning for now.

MShabara and others added 3 commits November 4, 2024 11:41
…im#1351)

* fixes the bug in the bodyClass for the QTFs and variable hydro

* fix QTF block issue - dont make it an atomic systme

---------

Co-authored-by: akeeste <akeeste@sandia.gov>
@akeeste
Copy link
Contributor

akeeste commented Nov 6, 2024

@dforbush2 I pull the most recent versions of dev and main into this branch and double checked the library for 4 recent bugfixes :

The tests passed again so I'll merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants