-
Notifications
You must be signed in to change notification settings - Fork 184
update body library block mask to address #1346 on dev branch #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fixing documentation inconsistency for PTO-Sim blocks * Adding comments to nondimensional values for clarification
* fix on pDis function call * preliminary fix for issue WEC-Sim#1288 * Update readAQWA.m (WEC-Sim#1253) * body mask fixes for WEC-Sim#1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
|
Thank you @dforbush2 |
|
I'll review this next week and may supercede it with a likely library fix needed in #1351 |
|
This PR now also adds hydro.gbm field creation as appropriate to readCapytaine. Revert commit 0abf01c to remove this if desired. This makes gbm modes specified in capytaine run out-of-the-box in wecSim, parallel functionality to what exists in readWAMIT with the following exception: Capytaine does not at this time allow the specification of non-zero mechanical inertia, mechanical damping, and mechanical stiffness in the BEM run itself. These fields, (hydro.gbm(:,:,[1:3], respectively) are all set to zero, but the last element hydro.gbm(:,:,4) is the hydrostatic stiffness which is calculated. This may need to be changed in a future capytaine update, and throws a warning for now. |
…im#1351) * fixes the bug in the bodyClass for the QTFs and variable hydro * fix QTF block issue - dont make it an atomic systme --------- Co-authored-by: akeeste <akeeste@sandia.gov>
|
@dforbush2 I pull the most recent versions of dev and main into this branch and double checked the library for 4 recent bugfixes :
The tests passed again so I'll merge this |
This is the equivalent of PR #1347 but made to the development branch. Credit to @hachikoi1 for finding the bug.