Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Oct 5, 2023

This PR fixes various minor bugs the prevent the WEC-Sim Applications tests from passing. WEC-Sim test pass locally, there is likely an issue with the runner using Windows and R2023b that needs further debugging.

Updates:

@kmruehl kmruehl changed the title Bug fixes for v0.6 Bug fixes for v6.0 Oct 5, 2023
@kmruehl kmruehl added the Bug bug in WEC-Sim source, high priority label Oct 5, 2023
@kmruehl kmruehl self-requested a review October 5, 2023 16:57
@kmruehl kmruehl self-assigned this Oct 5, 2023
@akeeste
Copy link
Contributor Author

akeeste commented Oct 5, 2023

@kmruehl Can you also take a look at updating run-tests-master.yml with any changes to run-tests-dev.yml? I couldn't quite follow the differences between the two

@akeeste akeeste linked an issue Oct 5, 2023 that may be closed by this pull request
@akeeste
Copy link
Contributor Author

akeeste commented Oct 5, 2023

The source requires one more bug fix which I will complete shortly. See the thread on WEC-Sim/WEC-Sim_Applications#47 for details.

@kmruehl
Copy link
Collaborator

kmruehl commented Oct 12, 2023

Thanks @akeeste, merging now and then I'll check Example for N Waves WEC-Sim_Applications#44

@kmruehl kmruehl merged commit b2c4564 into WEC-Sim:dev Oct 12, 2023
@akeeste akeeste deleted the testFixes branch October 12, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] WEC-Sim tests failing for MATLAB latest on windows-latest (2023b)

2 participants