Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Oct 5, 2023

This PR fixes various minor bugs the prevent the tests from passing.

  • updates the free decay cases to use body.adjMassFactor instead of simu.adjMassFactor
  • updates the MoorDyn input file for the Paraview RM3 application which uses MoorDyn
  • updates visualization of the MOST test results
  • updates MOST test results to be consistent with their most recent version
  • minor linting as I encountered things
  • fix issues with one WECCCOMP case and one wave marker case --> source issue, completed in WEC-Sim PR
  • Add mean drift test
  • standardize naming convention for radiation force options test

Also noting for future reference, that the error "Variable clock_out does not exist" is typically not helpful. Usually the clock_out variable does not exist because something else prevents Simulink from running.

@kmruehl kmruehl changed the title Bug fixes for v0.6 Bug fixes for v6.0 Oct 5, 2023
@kmruehl kmruehl self-requested a review October 5, 2023 16:58
@kmruehl kmruehl self-assigned this Oct 5, 2023
@kmruehl kmruehl added the bug label Oct 5, 2023
@akeeste
Copy link
Contributor Author

akeeste commented Oct 5, 2023

I still have an issues with seemingly random Applications (WECCCOMP_fault and Wave_Markers/RM3). When running the WECCCOMP_fault case locally, I see:

  • wecSim command + R2023b --> passes
  • wecSim command + R2023a --> passes
  • TestWECCCOMP + R2023b --> fails
  • TestWECCCOMP + R2023a --> fails

The WECCCOMP_fault test fails when using both the set-up from wecSimAppTest and a simple set-up:

t = TestWECCCOMP();
results = t.run();

Copying the set-up commands from wecSimAppTest is more robust though. It seems to keep the TestWECCCOMP.m file on the path and usable when changing directories.

@akeeste
Copy link
Contributor Author

akeeste commented Oct 5, 2023

Update: the error catching added to wecSim.m to allow MoorDyn 2.0 to work is what is causing the misleading error messages. I'll look at updating this so that the the error itself is thrown after MoorDyn is closed, giving useful debugging information

Now that I can see what errors are actually occurring, I've identified that the failing cases are related in that they all use the wave marker. There is a bug in the wave marker mask initialization command that only occurs when WEC-Sim is run in a function (like the tests). I will work on a fix shortly.

@akeeste akeeste mentioned this pull request Oct 5, 2023
6 tasks
@akeeste
Copy link
Contributor Author

akeeste commented Oct 6, 2023

Of the tests that are currently failing:

  • Wave Marker and WECCCOMP will pass on both R2020b and Latest once Bug fixes for v6.0 WEC-Sim#1136 is merged into dev
  • MoorDyn and Paraview RM3 with MoorDyn will continue to fail on both R2020b and Latest because we currently do not have a .so file for MoorDyn 2.0, which is required for Linux. WEC-Sim Applications Tests are currently only running on Linux.

@kmruehl
Copy link
Collaborator

kmruehl commented Oct 12, 2023

@akeeste I think we should remove the MoorDyn tests from the CI until they are running properly.

@kmruehl
Copy link
Collaborator

kmruehl commented Oct 12, 2023

I'm going to merge this and then update the tests directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants