-
Notifications
You must be signed in to change notification settings - Fork 57
Bug fixes for v6.0 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I still have an issues with seemingly random Applications (WECCCOMP_fault and Wave_Markers/RM3). When running the WECCCOMP_fault case locally, I see:
The WECCCOMP_fault test fails when using both the set-up from t = TestWECCCOMP();
results = t.run();Copying the set-up commands from |
|
Update: the error catching added to wecSim.m to allow MoorDyn 2.0 to work is what is causing the misleading error messages. I'll look at updating this so that the the error itself is thrown after MoorDyn is closed, giving useful debugging information Now that I can see what errors are actually occurring, I've identified that the failing cases are related in that they all use the wave marker. There is a bug in the wave marker mask initialization command that only occurs when WEC-Sim is run in a function (like the tests). I will work on a fix shortly. |
|
Of the tests that are currently failing:
|
|
@akeeste I think we should remove the MoorDyn tests from the CI until they are running properly. |
|
I'm going to merge this and then update the tests directly. |
This PR fixes various minor bugs the prevent the tests from passing.
body.adjMassFactorinstead ofsimu.adjMassFactorAlso noting for future reference, that the error "Variable clock_out does not exist" is typically not helpful. Usually the
clock_outvariable does not exist because something else prevents Simulink from running.