Multiple Wave Spectra #1130
Multiple Wave Spectra #1130
Conversation
| .. Note:: |
There was a problem hiding this comment.
@salhus Editorial Comment: can you please expand the existing note or add another note highlighting what combinations of features are compatible at this time. Based on theinitializeWECSim.m edits this would only be functional for regular, regularCIC, irregular, and spectrumImport.
Also clarify if the waveClass needs to be the same i.e. regularCIC and regularCIC or can there be a mix and match i.e. regularCIC and irregular.
There was a problem hiding this comment.
@nathanmtom
Thanks Nathan. I updated the note
| it = idx(kk); | ||
| body(it).hydroForcePre(waves.omega,waves.direction,simu.cicTime,waves.bem.count,simu.dt,... | ||
| simu.rho,simu.gravity,waves.type,waves.waveAmpTime,simu.stateSpace,simu.b2b); | ||
| body(it).hydroForcePre(waves(1).omega,waves(1).direction,simu.cicTime,waves(1).bem.count,simu.dt,... |
There was a problem hiding this comment.
@salhus I want to document discussion had on the previous PR to make sure they are captured upon merge. No action needed and placed a project board card to revisit this discussion in FY24.
"Moderate comment: Is there a reason that waves(1) is hard coded to the first wave instance? This seems to indicate that you cannot mix and match certain wave features. This relates to my request on documentation to state what combinations of sea states are possible.
Yes that is correct. I think this can be expanded and I am planning on enabling mix-n-match in next FY.
I will update documentation to reflect this limitation."
|
|
||
| % Waves and Simu: check inputs | ||
| waves.checkInputs(); | ||
| for iW = 1:length(waves) |
There was a problem hiding this comment.
@salhus Minor comment but can you update the stopWECSim.m to remove the iW variable that you generate through the for loop.
|
@salhus At this time, I do not have any additional feedback other than the recent request about the I'll focus on the applications PR now as additional change requests may come from running that case. |
| end | ||
| end | ||
|
|
||
| % Check for elevationImport with morisonElement |
There was a problem hiding this comment.
@salhus Minor request: May I ask that you add a check so if there is a mismatch in waves.type an error is thrown to stop the simulation. When I tried to break this code with this mismatch the error was not helpful in determining the issue.
This #1123 reintroduced to address compatibility issues.