-
Notifications
You must be signed in to change notification settings - Fork 57
Example for N Waves #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@salhus Thanks for resubmitting this PR. I've merged you're last PR into WEC-Sim/WEC-Sim for the updated body block. I will wait to see if the failed tests will not pass after re-running the jobs. However, I now have a few minor requests to update this PR:
If you can please make these changes and the tests pass then we should be able to merge. |
|
@nathanmtom Thanks for the recommendations. I updated the folder-name and the readme.md file. Cheers, |
|
@akeeste @kmruehl I see that @kmruehl approved this PR but we still have tests failing. Are we accepting these failed tests for the moment, or do @salhus and I need to dive further into resolving conflicts? I just want confirmation as the application and documentation are approved on my end but want to ensure we are providing the right tests. |
|
Hi @nathanmtom It looks like all of the failing tests were occurring previously. As long as the current The last thing to add the tests to the CI suite, which you can do by adding the application's folder to Lines 48-26 of the |
|
@nathanmtom I'm going to merge this PR then add the test to GitHub Actions and solve any other issues in #49 |
This is a reintroduction of PR #42