Example for N Waves #42

salhus · 2023-09-21T04:52:28Z

This is the accompnaying PR to WEC-Sim/WEC-Sim#1123

nathanmtom · 2023-09-27T05:53:11Z

@salhus Prior to completing my review can you change the repository you are pushing this PR to from WEC-Sim:master to WEC-Sim:Dev for the WEC-Sim Applications Repository.

nathanmtom · 2023-09-27T22:12:30Z

Passive_Yaw_with_N_Waves/PassiveYawOFF/OSWEC.slx

@salhus Suggest deleting since this is not used to demonstrate new feature.

nathanmtom · 2023-09-27T22:12:41Z

Passive_Yaw_with_N_Waves/PassiveYawOFF/wecSimInputFile.m

@salhus Suggest deleting since this is not used to demonstrate new feature.

nathanmtom · 2023-09-27T22:13:51Z

Passive_Yaw_with_N_Waves/README.md

@salhus This README.md needs to be update to reflect the N Waves implementation.

@nathanmtom

done

nathanmtom · 2023-09-27T22:14:33Z

Passive_Yaw_with_N_Waves/TestPassiveYaw.m

@salhus Please ensure this is updated to reflect your N Waves updates.

nathanmtom · 2023-09-27T22:16:54Z

Passive_Yaw_with_N_Waves/plotYawCases.m

@salhus I do not believe this file is needed. If you are trying to compare with passive yaw on and off with N Waves then please update as required.

@nathanmtom

done

doc credits

nathanmtom · 2023-09-28T19:02:13Z

Passive_Yaw_with_N_Waves/runYawCases.m

@salhus This file does not seem required as we are not plotting the two Yaw Cases, nor is plotYawCases included.

Suggestion is to remove this file.

nathanmtom · 2023-09-28T19:05:20Z

Passive_Yaw_with_N_Waves/PassiveYawON/wecSimInputFile.m

+pto(1).stiffness = 0;                                   % PTO Stiffness Coeff [Nm/rad]
+pto(1).damping = 120000;                               % PTO Damping Coeff [Nsm/rad]
+pto(1).location = [0 0 -8.9];                        % PTO Location [m]
+% pto(1).orientation.z=[0 1 0]; % switching so device will yaw


@salhus Did you want to allow the OSWEC to Yaw based on the multiple wave directions? If not we can probably delete lines 78-79 and relabel this folder as "Multiple_Waves" as we would not be demonstrating the passive yaw feature.

@nathanmtom
Yes, if someone wants to check if the different wave-directions have an impact.

@salhus Apologies, last minor comment here but if you want the OSWEC to yaw then lines 79-80 would have to be uncommented. When I run the application with these lines uncommented there is not much yaw motion since the wave directions are either perpendicular or parallel without spreading.

Recommendation is to either delete these lines and keep the OSWEC rotating about the y-axis as designed or uncomment the lines and have one wave group come from 45 degrees to induce greater yaw motion.

Thanks @nathanmtom
I deleted 78-79 to keep the demo more clear.

nathanmtom · 2023-09-28T19:06:07Z

Passive_Yaw_with_N_Waves/README.md

+**Geometry**	OSWEC
+
+
+Example on using [N-Wave Spectra](http://wec-sim.github.io/WEC-Sim/advanced_features.html#NWave) with [Passive Yaw](http://wec-sim.github.io/WEC-Sim/advanced_features.html#passive-yaw-implementation) to run WEC-Sim for the [OSWEC](http://wec-sim.github.io/WEC-Sim/tutorials.html#oscillating-surge-wec-oswec) geometry. Execute the `runYawCases.m` script to run this case. 


@salhus Need to remove Execute the 'runYawCases.m' script to run this case. If you decide to eliminate that function.

@nathanmtom

done, after the latest push

nathanmtom · 2023-09-28T19:07:24Z

Passive_Yaw_with_N_Waves/PassiveYawON/wecSimInputFile.m

+waves(1).period = 3;                       % Wave Period [s]
+waves(1).spectrumType = 'PM';
+waves(1).direction = 0;
+waves(1).spread = 1;


@salhus suggest removing line 20 and line 38 as the default spread option is already 1 so this is not necessary.

done, in the latest push

nathanmtom · 2023-09-28T19:09:17Z

Passive_Yaw_with_N_Waves/PassiveYawON/elevationData.mat

@salhus Moderate request: The current example is for irregular so this .mat file would be unnecessary; however, it may be worth creating several examples for each wave type (i.e. regular, regularCIC, irregular, spectrumImport, and elevationImport) to be run to ensure this added capability is not broken with other updates.

Your decision on how you would like to proceed.

removed after the latest push,

done

nathanmtom · 2023-09-28T19:41:27Z

Thanks @salhus, I have no further comments on this PR. Thank you for addressing my comments.

I'll plan to merge this PR once the WEC-Sim/WEC-Sim PR that enables this feature is merged and final checks are completed.

nathanmtom · 2023-09-28T22:59:13Z

@salhus Apologies, but something in the last few commits appears to be causing additional test cases to fail. Can you review and see if you can identify why this might be. Unfortunately, I do not want to merge until we know the cause and if it can be fixed.

salhus · 2023-09-28T23:09:46Z

@nathanmtom
Hi Nathan,
I am quite puzzled and trying to figure out as well. I will update you when I understand what is happening.

Example for N Waves

b23bc92

salhus requested a review from nathanmtom September 21, 2023 04:53

nathanmtom self-assigned this Sep 27, 2023

salhus changed the base branch from master to dev September 27, 2023 21:31

nathanmtom reviewed Sep 27, 2023

View reviewed changes

salhus added 4 commits September 27, 2023 16:19

remove extra folders

94c52d0

Update README.md

40b32af

doc credits

minor cleanup

e73340f

Delete plotYawCases.m

3e66acb

nathanmtom reviewed Sep 28, 2023

View reviewed changes

update and simply application case for n wave

0261e20

nathanmtom added the enhancement label Sep 28, 2023

salhus added 3 commits September 28, 2023 14:35

Update wecSimInputFile.m

1dd4242

update wave markers example to have color

e117042

Update TestPassiveYawNWaves.m

97910d9

Update TestPassiveYawNWaves.m

ad73a3a

salhus mentioned this pull request Sep 28, 2023

Example for N Waves #44

Merged

salhus closed this Sep 29, 2023

salhus deleted the Example_Nwave_Sept23 branch October 4, 2023 18:40

		Geometry OSWEC


		Example on using [N-Wave Spectra](http://wec-sim.github.io/WEC-Sim/advanced_features.html#NWave) with [Passive Yaw](http://wec-sim.github.io/WEC-Sim/advanced_features.html#passive-yaw-implementation) to run WEC-Sim for the [OSWEC](http://wec-sim.github.io/WEC-Sim/tutorials.html#oscillating-surge-wec-oswec) geometry. Execute the `runYawCases.m` script to run this case.

Example for N Waves #42

Example for N Waves #42

Uh oh!

Conversation

salhus commented Sep 21, 2023

Uh oh!

nathanmtom commented Sep 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathanmtom commented Sep 28, 2023

Uh oh!

nathanmtom commented Sep 28, 2023

Uh oh!

salhus commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants