Implement the wrap function with the asyncio.to_thread underneath.#213
Closed
stankudrow wants to merge 26 commits intoTinche:mainfrom
Closed
Implement the wrap function with the asyncio.to_thread underneath.#213stankudrow wants to merge 26 commits intoTinche:mainfrom
wrap function with the asyncio.to_thread underneath.#213stankudrow wants to merge 26 commits intoTinche:mainfrom
Conversation
stankudrow
commented
Apr 26, 2025
asyncio to thread in the wrapasyncio.to thread in the wrap
stankudrow
commented
Apr 30, 2025
stankudrow
commented
Apr 30, 2025
stankudrow
commented
Apr 30, 2025
asyncio.to thread in the wrapwrap in favour of the new asyncify wrapper.
wrap in favour of the new asyncify wrapper.wrap function.
wrap function.to_coro function with the asyncio.to_thread under -> deprecating the wrap function.
Contributor
Author
stankudrow
added a commit
to stankudrow/aiofiles
that referenced
this pull request
May 26, 2025
6f98dc2 to
83a4442
Compare
to_coro function with the asyncio.to_thread under -> deprecating the wrap function.to_coro function with the asyncio.to_thread underneath -> deprecating the wrap function.
83a4442 to
4312783
Compare
stankudrow
pushed a commit
to stankudrow/aiofiles
that referenced
this pull request
Jun 20, 2025
stankudrow
pushed a commit
to stankudrow/aiofiles
that referenced
this pull request
Jun 21, 2025
added 2 commits
June 21, 2025 20:30
Contributor
Author
|
@Tinche , hello. Could you possibly have a look at this PR? |
Owner
|
I don't see a ton of value in the |
to_coro function with the asyncio.to_thread underneath -> deprecating the wrap function.wrap function with the asyncio.to_thread underneath.
Tinche
requested changes
Aug 10, 2025
stankudrow
commented
Aug 30, 2025
stankudrow
commented
Aug 30, 2025
stankudrow
commented
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
wrap-> base::asyncio.to_threadjust checkCloses #207 .
Makes the #177 obsolete (actually done by the #209).