Merged
Conversation
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
stankudrow
commented
May 5, 2025
Tinche
requested changes
May 10, 2025
Contributor
Author
|
@Tinche , hello. The PR is ready for the next round. |
Tinche
approved these changes
May 26, 2025
Owner
Tinche
left a comment
There was a problem hiding this comment.
LGTM. I haven't looked too closely at the choice of rules, trusting you with the selection ;)
Contributor
Author
Thank you, I think this config will do. |
stankudrow
added a commit
to stankudrow/aiofiles
that referenced
this pull request
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff is both formatter and linter. It can replace black and flake8 tools.
A lot of ruff rules are selected, but some are commented for future chores.
The code was formatted and linted with
ruff, yet some rules that required manual intervention:Extra changes:
Resolves the discussion #215 .
Good to go before #213 and maybe any other open PR.