Move wrap into the "base.py" module.#209
Merged
Tinche merged 4 commits intoTinche:mainfrom Feb 8, 2025
Merged
Conversation
stankudrow
commented
Feb 3, 2025
Tinche
requested changes
Feb 6, 2025
a856941 to
67e72c9
Compare
Contributor
Author
|
When this PR is done, we can move on to the #207 . |
Tinche
approved these changes
Feb 8, 2025
Owner
|
Cool, thanks! |
stankudrow
pushed a commit
to stankudrow/aiofiles
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info:
wrapfunction the base.py module. #208 ;to_agenwrapper andaiofiles.os.walkandaiofiles.os.fwalk. #193 ;The wrapped functin from the "os.py" and "ospath.py" modules are sorted and the latter module defines the
__all__variable, so these modules are "aligned". These changes are unrelated, but I think they are good to have.