src/renderer/src/i18n/en-US/common.json (1)

75-76: LGTM: Shared “Saved” key added

Key is correctly placed in common.json and matches usage expectations.

Note: See the FA-IR comment for a repository-wide verification script ensuring this key exists across all locales.

src/renderer/src/i18n/zh-HK/common.json (1)

75-77: Unify terminology: use Traditional HK form consistent with "save"

"save" is translated as "儲存", but "saved" is "已保存". For zh-HK, prefer "已儲存" to stay consistent and avoid Simplified usage.

-  "saved": "已保存"
+  "saved": "已儲存"

src/renderer/src/i18n/ko-KR/common.json (1)

75-77: Adjust "saved" to avoid collision with "save"

Currently both "save" and "saved" are "저장". Suggest "저장됨" for the past/complete state, which is standard in Korean UIs.

-  "saved": "저장"
+  "saved": "저장됨"

src/renderer/src/i18n/ru-RU/common.json (1)

75-77: Fix Russian aspect: use neutral passive form

"Сохранил" reads as “He saved”. For status labels, use "Сохранено".

-  "saved": "Сохранил"
+  "saved": "Сохранено"

src/renderer/src/i18n/zh-TW/common.json (1)

75-76: Nit: Prefer TW phrasing “已儲存” for consistency with “儲存”

For zh-TW, “儲存” is used for the “save” label; aligning the past tense to “已儲存” improves locale consistency.

Apply:

-  "saved": "已保存"
+  "saved": "已儲存"

src/renderer/src/i18n/fr-FR/settings.json (1)

632-633: French phrasing + consistency: prefer “clé API” and adjust style

• “Apikey” is not idiomatic French. Use “clé API” and neutral phrasing.
• Optional: “fonctionnalité” reads more natural than “fonction” in UX copy.

Proposed update:

-      "e2bApiKeyRequired": "Apikey doit être entré pour activer la fonction E2B",
+      "e2bApiKeyRequired": "La clé API est requise pour activer la fonctionnalité E2B",

src/renderer/src/i18n/fr-FR/common.json (1)

75-76: Use the correct French past participle for “Saved”

“Sauvé” is unnatural in this UX context. Prefer “Enregistré” (consistent with “Enregistrer”).

-  "saved": "Sauvé"
+  "saved": "Enregistré"

src/renderer/src/i18n/fr-FR/routes.json (1)

13-15: Minor casing/style consistency for French

French UI labels generally avoid capitalizing common nouns mid-sentence. Consider lowercasing “Prompts” for consistency with other entries.

-  "settings-prompt": "Gestion des Prompts",
+  "settings-prompt": "Gestion des prompts",

“Marché MCP” looks good.

src/renderer/src/i18n/ru-RU/routes.json (1)

14-15: Localize the new route label into Russian

Currently the value is in English. Consider translating for consistency with other RU labels.

Suggested change:

-  "settings-mcp-market": "MCP Market"
+  "settings-mcp-market": "Рынок MCP"

If you prefer a different style (e.g., "Маркет MCP"), I can update across locales for consistency notes.

src/renderer/src/i18n/fa-IR/settings.json (1)

640-642: Polish Persian punctuation and term consistency (comma spacing + API Key phrasing).

• Remove the space before the Persian comma in clickToEdit.
• Prefer consistent terminology for API keys. Suggest "API Key" phrasing over "Apikey" and a more natural sentence.

Apply this diff:

-      "e2bApiKeyRequired": "برای فعال کردن عملکرد E2B باید Apikey وارد شود",
-      "clickToEdit": "برای مشاهده مطالب کامل ، روی ویرایش کلیک کنید"
+      "e2bApiKeyRequired": "برای فعال‌سازی E2B، وارد کردن API Key الزامی است",
+      "clickToEdit": "برای مشاهده مطالب کامل، روی ویرایش کلیک کنید"

src/renderer/src/i18n/ja-JP/common.json (1)

75-77: Clarify “saved” usage context for Japanese translation

The "saved" key is present in every common.json under src/renderer/src/i18n, so updating the Japanese file won’t introduce missing keys elsewhere. Please confirm whether this label is shown as:

• a persistent status/state (e.g. “Status: Saved”)
  → use “保存済み”
• a one-time toast/message after an action
  → use “保存しました”

Once confirmed, apply one of:

--- a/src/renderer/src/i18n/ja-JP/common.json
+++ b/src/renderer/src/i18n/ja-JP/common.json
@@ -74,3 +74,4 @@
   "clear": "クリア",
-  "saved": "保存"
+  "saved": "保存済み"
 }

--- a/src/renderer/src/i18n/ja-JP/common.json
+++ b/src/renderer/src/i18n/ja-JP/common.json
@@ -74,3 +74,4 @@
   "clear": "クリア",
-  "saved": "保存"
+  "saved": "保存しました"
 }

src/renderer/src/i18n/ru-RU/settings.json (1)

632-634: Unify “API key” terminology and improve sentence style.

Use “ключ API” (or “API‑ключ”) consistently across RU locale, and prefer a more natural construction.

Apply this diff:

-      "e2bApiKeyRequired": "Apikey должен быть введен, чтобы включить функцию E2B",
+      "e2bApiKeyRequired": "Для включения функции E2B необходимо ввести ключ API",

src/renderer/src/i18n/ko-KR/mcp.json (1)

249-268: Standardize MCPRouter brand and improve Korean phrasing (more natural, consistent formal tone).

Current strings mix “McProuter” and contain machine-translated/awkward phrasing. Suggested edits below keep the existing formal imperative tone “-하십시오” used elsewhere in this file and unify branding to “MCPRouter”.

-    "apiKeyPlaceholder": "McProuter API 키를 입력하십시오",
-    "apiKeyRequiredDesc": "설치하기 전에 먼저 McProuter API 키를 작성하십시오.",
+    "apiKeyPlaceholder": "MCPRouter API 키를 입력하십시오",
+    "apiKeyRequiredDesc": "설치 전에 먼저 MCPRouter API 키를 입력하십시오.",
     "apiKeyRequiredTitle": "API 키가 필요합니다",
-    "browseBuiltin": "내장 MCP 시장을 찾아보십시오",
+    "browseBuiltin": "내장 MCP 시장 둘러보기",
     "builtinTitle": "MCP 시장",
-    "empty": "아직 서비스가 없습니다",
-    "install": "설치하다",
-    "installFailed": "설치가 실패했습니다",
-    "installSuccess": "성공적으로 설치",
-    "installed": "설치",
-    "keyGuide": "열쇠를 얻으십시오",
-    "keyHelpEnd": "API 키를 신청 한 후 위의 입력 상자를 채우십시오.",
-    "keyHelpText": "먼저 도착하십시오",
-    "loadMore": "더로드하십시오",
-    "noMore": "더 이상",
-    "poweredBy": "McProuter에 의해 구동",
-    "pullDownToLoad": "더 많은로드하기 위해 계속 드롭 다운하십시오"
+    "empty": "표시할 서비스가 없습니다",
+    "install": "설치",
+    "installFailed": "설치 실패",
+    "installSuccess": "설치 성공",
+    "installed": "설치됨",
+    "keyGuide": "키 발급",
+    "keyHelpEnd": "API 키를 신청한 후 위의 입력란에 입력하십시오.",
+    "keyHelpText": "먼저 다음으로 이동하십시오",
+    "loadMore": "더 불러오기",
+    "noMore": "더 이상 없음",
+    "poweredBy": "MCPRouter 제공",
+    "pullDownToLoad": "더 불러오려면 아래로 당기십시오"

src/renderer/src/i18n/zh-CN/mcp.json (1)

253-253: Localize the “Powered by” label to Chinese.

Keep brand as “MCPRouter” but localize the phrase for consistency with the rest of zh-CN UI text.

-    "poweredBy": "Powered by MCPRouter",
+    "poweredBy": "由 MCPRouter 提供支持",

src/renderer/src/i18n/ru-RU/mcp.json (1)

249-268: Fix Russian grammar and unify “MCPRouter” brand.

Several phrases are unnatural, and the brand is inconsistently cased. Suggested improvements below.

-    "apiKeyPlaceholder": "Введите ключ McProuter API",
-    "apiKeyRequiredDesc": "Пожалуйста, заполните клавишу McProuter API сначала перед установкой",
-    "apiKeyRequiredTitle": "Требует ключа API",
-    "browseBuiltin": "Просмотрите встроенный рынок MCP",
-    "builtinTitle": "MCP Market",
-    "empty": "Пока нет услуг",
+    "apiKeyPlaceholder": "Введите ключ API MCPRouter",
+    "apiKeyRequiredDesc": "Пожалуйста, укажите ключ API MCPRouter перед установкой.",
+    "apiKeyRequiredTitle": "Требуется ключ API",
+    "browseBuiltin": "Просмотреть встроенный рынок MCP",
+    "builtinTitle": "Рынок MCP",
+    "empty": "Сервисы отсутствуют",
     "install": "Установить",
-    "installFailed": "Установка не удалась",
-    "installSuccess": "Установка успешно",
-    "installed": "Установлен",
-    "keyGuide": "Получите ключ",
-    "keyHelpEnd": "После подачи заявки на ключ API заполните поле ввода выше",
-    "keyHelpText": "Пожалуйста, приезжайте первым",
-    "loadMore": "Загружать больше",
-    "noMore": "Больше не надо",
-    "poweredBy": "Оборудован от McProuter",
-    "pullDownToLoad": "Продолжайте падать, чтобы загружать больше"
+    "installFailed": "Не удалось установить",
+    "installSuccess": "Установка выполнена успешно",
+    "installed": "Установлено",
+    "keyGuide": "Где получить ключ",
+    "keyHelpEnd": "После получения ключа API укажите его в поле выше.",
+    "keyHelpText": "Сначала перейдите на",
+    "loadMore": "Загрузить ещё",
+    "noMore": "Больше нет",
+    "poweredBy": "Работает на базе MCPRouter",
+    "pullDownToLoad": "Потяните вниз, чтобы загрузить ещё"

src/renderer/src/i18n/fa-IR/mcp.json (1)

250-268: Improve Persian phrasing and unify “MCPRouter” brand.

A few strings read unnatural or use inconsistent capitalization. Suggested edits below use idiomatic Persian and correct punctuation.

-    "apiKeyPlaceholder": "کلید API MCPROUTER را وارد کنید",
-    "apiKeyRequiredDesc": "لطفاً قبل از نصب ، ابتدا کلید API McProuter را پر کنید",
-    "apiKeyRequiredTitle": "به کلید API نیاز دارد",
+    "apiKeyPlaceholder": "کلید API MCPRouter را وارد کنید",
+    "apiKeyRequiredDesc": "لطفاً پیش از نصب، ابتدا کلید API MCPRouter را وارد کنید.",
+    "apiKeyRequiredTitle": "نیاز به کلید API",
     "browseBuiltin": "مرور بازار داخلی MCP",
     "builtinTitle": "بازار MCP",
-    "empty": "هنوز هیچ خدمتی وجود ندارد",
-    "install": "نصب کردن",
-    "installFailed": "نصب انجام نشد",
-    "installSuccess": "نصب با موفقیت",
+    "empty": "هیچ خدمتی موجود نیست",
+    "install": "نصب",
+    "installFailed": "نصب ناموفق بود",
+    "installSuccess": "نصب با موفقیت انجام شد",
     "installed": "نصب شده",
-    "keyGuide": "کلید را دریافت کنید",
-    "keyHelpEnd": "پس از درخواست کلید API ، کادر ورودی را در بالا پر کنید",
-    "keyHelpText": "لطفا ابتدا وارد شوید",
-    "loadMore": "بار بیشتر",
-    "noMore": "نه بیشتر",
-    "poweredBy": "نیرو توسط McProuter",
-    "pullDownToLoad": "برای بارگیری بیشتر به پایین بیاید"
+    "keyGuide": "دریافت کلید",
+    "keyHelpEnd": "پس از دریافت کلید API، آن را در کادر بالا وارد کنید.",
+    "keyHelpText": "ابتدا به",
+    "loadMore": "بارگذاری بیشتر",
+    "noMore": "مورد بیشتری نیست",
+    "poweredBy": "قدرت‌گرفته از MCPRouter",
+    "pullDownToLoad": "برای بارگذاری بیشتر پایین بکشید"

src/shared/presenter.d.ts (1)

991-993: Consider adding JSDoc comments for the new source tracking fields.

The source and sourceId fields enable tracking of server origins, which is crucial for the marketplace integration. However, their purpose and expected values should be documented for better maintainability.

Add documentation to clarify the purpose and expected values:

-  source?: string // 来源标识: "mcprouter" | "modelscope" | undefined(for manual)
-  sourceId?: string // 来源ID: mcprouter的uuid 或 modelscope的mcpServer.id
+  /** Source identifier indicating where the server configuration originated from */
+  source?: 'mcprouter' | 'modelscope' // undefined for manually added servers
+  /** Unique identifier from the source system (e.g., UUID for mcprouter, server.id for modelscope) */
+  sourceId?: string

src/renderer/src/components/mcp-config/mcpServerForm.vue (1)

556-574: Consider extracting the masking logic to a utility function.

The maskSensitiveValue function could be useful in other parts of the application where sensitive data needs to be displayed. Consider moving it to a shared utility module for reusability.

Create a shared utility function:

// src/renderer/src/utils/sensitive.ts
export function maskSensitiveValue(value: string): string {
  return value.replace(/=(.+)/g, (_, val) => {
    const trimmedVal = val.trim()
    if (trimmedVal.length <= 4) {
      return '=' + '*'.repeat(trimmedVal.length)
    } else if (trimmedVal.length <= 12) {
      return '=' + trimmedVal.substring(0, 1) + '*'.repeat(6)
    } else {
      const start = trimmedVal.substring(0, 2)
      const end = trimmedVal.substring(trimmedVal.length - 2)
      return '=' + start + '*'.repeat(8) + end
    }
  })
}

Then import and use it in the component:

+import { maskSensitiveValue } from '@/utils/sensitive'

-const maskSensitiveValue = (value: string): string => {
-  // ... existing implementation
-}

src/main/presenter/mcpPresenter/mcprouterManager.ts (1)

40-41: Consider using environment variables for API endpoints

The API endpoints are hardcoded. Consider moving them to a configuration file or environment variables for better maintainability and to support different environments (development, staging, production).

-const LIST_ENDPOINT = 'https://api.mcprouter.to/v1/list-servers'
-const GET_ENDPOINT = 'https://api.mcprouter.to/v1/get-server'
+const LIST_ENDPOINT = process.env.MCPROUTER_LIST_ENDPOINT || 'https://api.mcprouter.to/v1/list-servers'
+const GET_ENDPOINT = process.env.MCPROUTER_GET_ENDPOINT || 'https://api.mcprouter.to/v1/get-server'

src/renderer/src/components/settings/McpBuiltinMarket.vue (3)

140-147: Add error handling for loadApiKey

The loadApiKey function silently catches all errors. Consider at least logging errors for debugging purposes.

 const loadApiKey = async () => {
   try {
     const key = await mcpP.getMcpRouterApiKey?.()
     apiKeyInput.value = key || ''
-  } catch {}
+  } catch (error) {
+    console.error('Failed to load MCP Router API key:', error)
+  }
 }

---

169-183: Performance: Consider batch checking installation status

The current implementation checks installation status one by one. For better performance, consider implementing a batch check method.

 const checkInstalledServers = async () => {
   const installed = new Set<string>()
-  for (const item of items.value) {
-    try {
-      // 使用 server_key 作为 sourceId 检查安装状态，因为这是我们在安装时保存的标识符
-      const isInstalled = await mcpP.isServerInstalled?.('mcprouter', item.server_key)
-      if (isInstalled) {
-        installed.add(item.server_key)
-      }
-    } catch (e) {
-      console.error('Failed to check installation status:', e)
-    }
-  }
+  // Consider implementing a batch check method in the presenter
+  const serverKeys = items.value.map(item => item.server_key)
+  try {
+    // This would require implementing a new batch check method
+    const installationStatuses = await mcpP.batchCheckServerInstallation?.('mcprouter', serverKeys)
+    if (installationStatuses) {
+      installationStatuses.forEach((status, index) => {
+        if (status) {
+          installed.add(serverKeys[index])
+        }
+      })
+    }
+  } catch (e) {
+    console.error('Failed to batch check installation status:', e)
+    // Fallback to individual checks
+    for (const item of items.value) {
+      try {
+        const isInstalled = await mcpP.isServerInstalled?.('mcprouter', item.server_key)
+        if (isInstalled) {
+          installed.add(item.server_key)
+        }
+      } catch (e) {
+        console.error('Failed to check installation status:', e)
+      }
+    }
+  }
   installedServers.value = installed
 }

---

286-296: Potential race condition with setTimeout

Using setTimeout to check content height after mounting could lead to race conditions. Consider using nextTick or MutationObserver for more reliable detection.

 onMounted(async () => {
   await loadApiKey()
   await fetchPage()

   // 初始加载后检查是否需要启用强制拉取模式
-  setTimeout(() => {
+  await nextTick()
     const el = scrollContainer.value
     if (el && !hasMore.value) {
       const contentTooShort = el.scrollHeight <= el.clientHeight
       if (contentTooShort && items.value.length > 0) {
         canPullMore.value = true
         showPullToLoad.value = true
       }
     }
-  }, 100)
 })

src/main/presenter/mcpPresenter/index.ts (2)

217-220: Consider adding error details for better debugging

The error message could be more descriptive to help with debugging.

   async installMcpRouterServer(serverKey: string): Promise<boolean> {
-    if (!this.mcprouter) throw new Error('McpRouterManager not available')
+    if (!this.mcprouter) throw new Error('McpRouterManager not available - initialization may have failed')
     return this.mcprouter.installServer(serverKey)
   }

---

240-263: Consider optimizing batch updates

The updateMcpRouterServersAuth method could be optimized by batching all updates into a single configuration save operation instead of multiple individual updates.

   async updateMcpRouterServersAuth(apiKey: string): Promise<void> {
     const servers = await this.configPresenter.getMcpServers()
-    const updates: Array<{ name: string; config: Partial<MCPServerConfig> }> = []
+    const updatedServers = { ...servers }
+    let updateCount = 0

     for (const [serverName, config] of Object.entries(servers)) {
       if (config.source === 'mcprouter' && config.customHeaders) {
         const updatedHeaders = {
           ...config.customHeaders,
           Authorization: `Bearer ${apiKey}`
         }
-        updates.push({
-          name: serverName,
-          config: { customHeaders: updatedHeaders }
-        })
+        updatedServers[serverName] = {
+          ...config,
+          customHeaders: updatedHeaders
+        }
+        updateCount++
       }
     }

-    // 批量更新所有服务器的 Authorization
-    for (const update of updates) {
-      await this.configPresenter.updateMcpServer(update.name, update.config)
-    }
+    // Single batch update
+    if (updateCount > 0) {
+      await this.configPresenter.setMcpServers(updatedServers)
+    }

-    console.log(`Updated Authorization for ${updates.length} mcprouter servers`)
+    console.log(`Updated Authorization for ${updateCount} mcprouter servers`)
   }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/common.json : Shared translation keys must be placed in 'src/renderer/src/i18n/common.json'

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : When adding new translations, add shared keys to 'common.json' and language-specific keys to the respective language file; keep all language files' keys consistent

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Utilize Vue Router for navigation and route management

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/mcpPresenter/inMemoryServers/*.ts : Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : `src/main/presenter/llmProviderPresenter/index.ts` should manage the overall Agent loop, conversation history, tool execution via `McpPresenter`, and frontend communication via `eventBus`.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., using `convertToProviderTools`) and included in the API request.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add provider configuration in configPresenter/providers.ts when adding a new LLM provider

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider files should implement helper methods such as `formatMessages`, `convertToProviderTools`, `parseFunctionCalls`, and `prepareFunctionCallPrompt` as needed for provider-specific logic.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.880Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Each file in `src/main/presenter/llmProviderPresenter/providers/*.ts` should handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.