src/renderer/src/components/mcp-config/mcpServerForm.vue (1)

922-934: Hiding the generic env editor for Powerpack may block advanced users

For powerpack servers the standard env textarea is completely hidden.
Users can no longer tweak unrelated variables (e.g. HTTP_PROXY) without switching to JSON import.

Recommend leaving the textarea visible (perhaps collapsed) or adding an “advanced” toggle so users still have full control.

src/main/presenter/mcpPresenter/mcpClient.ts (1)

567-570: Replicate the above fix for the failure branch

When the connection fails you emit the stopped status with the same argument order.
If the order needs swapping (see previous comment) remember to adjust here as well to keep behaviour symmetrical.

src/main/presenter/mcpPresenter/index.ts (1)

384-386: Possible duplicate SERVER_STOPPED event

If stopServer() succeeds it already calls eventBus.send(MCP_EVENTS.SERVER_STOPPED …).
When the subsequent startServer() fails, this extra send emits the same event twice.

Not harmful, but listeners doing state transitions or analytics could double-count.
Wrap the second send with a guard:

-        eventBus.send(MCP_EVENTS.SERVER_STOPPED, SendTarget.ALL_WINDOWS, serverName)
+        if (!this.serverManager.isServerRunning(serverName)) {
+          eventBus.send(MCP_EVENTS.SERVER_STOPPED, SendTarget.ALL_WINDOWS, serverName)
+        }

src/main/presenter/configPresenter/mcpConfHelper.ts (1)

249-255: Broadcast OK – but consider debouncing CONFIG_CHANGED

Every write to ElectronStore now emits CONFIG_CHANGED immediately. Bulk edits (e.g. import JSON) trigger many rapid sends and can flood renderer IPC.

Add a short debounce/throttle around eventBus.send inside setters (setMcpServers, add/remove/toggle…) to coalesce updates.

No functional bug, just performance polish.

src/renderer/src/i18n/ja-JP/settings.json (1)

380-386: Minor JP localisation fixes

Typo & consistency:

-"useE2B": "E2Bサンドボックスを有効にします",
-"e2bDescription": "E2Bサンドボックスを使用してPythonコードを実行します",
-"e2bApiKey": "E2B Apikey",
-"e2bApiKeyPlaceholder": "e2b_1111xx *******など、E2B APIキーをこちらから入力してください。",
-"e2bApiKeyHelp": "e2b.devにアクセスして、アピケイを取得します",
-"e2bApiKeyRequired": "E2B関数を有効にするには、Apikeyを入力する必要があります"
+"useE2B": "E2Bサンドボックスを有効化",
+"e2bDescription": "E2Bサンドボックスで Python コードを実行します",
+"e2bApiKey": "E2B APIキー",
+"e2bApiKeyPlaceholder": "例: e2b_************",
+"e2bApiKeyHelp": "e2b.dev で APIキーを取得してください",
+"e2bApiKeyRequired": "E2B を有効にするには APIキーが必要です"

(“Apikey”→“APIキー”, “アピケイ” typo).

src/main/presenter/mcpPresenter/mcpClient.ts (1)

6-6: Unused named import SendTarget before first usage

SendTarget is imported here, but the first usage is ~530 lines later.
Consider re-ordering the import list alphabetically or grouping by package to avoid large temporal gaps between declaration and usage.
(This is only a style/readability concern; feel free to ignore if your code-style rules already allow this.)

src/renderer/src/i18n/en-US/settings.json (1)

388-395: Terminology consistency: API key vs ApiKey

Across the English locale file the phrase is always written as “API Key” (e.g. lines 164-166).
The newly added strings use “ApiKey”/“Api Keys”.

- "e2bApiKey": "E2B ApiKey",
- "e2bApiKeyPlaceholder": "Enter your E2B Api Keys here, such as e2b_1111xx*******",
- "e2bApiKeyHelp": "Go to e2b.dev to get your ApiKey",
- "e2bApiKeyRequired": "ApiKey must be entered to enable E2B function"
+ "e2bApiKey": "E2B API Key",
+ "e2bApiKeyPlaceholder": "Enter your E2B API key here, e.g. e2b_1111xx*******",
+ "e2bApiKeyHelp": "Visit e2b.dev to obtain your API key",
+ "e2bApiKeyRequired": "An API key is required to enable the E2B sandbox"

src/renderer/src/i18n/zh-CN/settings.json (1)

387-394: 用词统一：ApiKey → API密钥

当前新增字段与同文件中 272 行的 “API密钥” 不一致，建议保持统一：

- "useE2B": "启用E2B沙盒",
- "e2bDescription": "使用E2B沙盒执行Python代码",
- "e2bApiKey": "E2B ApiKey",
- "e2bApiKeyPlaceholder": "这里输入你的E2B Api Keys，如 e2b_1111xx*****",
- "e2bApiKeyHelp": "前往 e2b.dev 获取你的 ApiKey",
- "e2bApiKeyRequired": "启用E2B功能必须要输入 ApiKey"
+ "useE2B": "启用 E2B 沙盒",
+ "e2bDescription": "使用 E2B 沙盒执行 Python 代码",
+ "e2bApiKey": "E2B API 密钥",
+ "e2bApiKeyPlaceholder": "请输入 E2B API 密钥，例如 e2b_1111xx*****",
+ "e2bApiKeyHelp": "前往 e2b.dev 获取 API 密钥",
+ "e2bApiKeyRequired": "启用 E2B 功能必须输入 API 密钥"

src/renderer/src/i18n/zh-TW/settings.json (1)

380-387: 統一專有名詞大小寫

建議將 ApiKey 全文改為「API 金鑰」以符合 272 行等處既有用法；同時微調語句以符合同文件格式。

src/renderer/src/i18n/fr-FR/settings.json (1)

380-386: Accent & capitalisation corrections

Pour rester cohérent :

- "useE2B": "Activer E2B Sandbox",
- "e2bDescription": "Exécuter le code Python à l'aide de Sandbox E2B",
- "e2bApiKey": "E2B APIKEY",
- "e2bApiKeyPlaceholder": "Entrez ici vos touches API E2B, comme E2B_1111XX *******",
- "e2bApiKeyHelp": "Allez sur e2b.dev pour obtenir votre apikey",
- "e2bApiKeyRequired": "Apikey doit être entré pour activer la fonction E2B"
+ "useE2B": "Activer le bac à sable E2B",
+ "e2bDescription": "Exécuter du code Python via le bac à sable E2B",
+ "e2bApiKey": "Clé API E2B",
+ "e2bApiKeyPlaceholder": "Saisissez votre clé API E2B, ex. e2b_1111xx*******",
+ "e2bApiKeyHelp": "Visitez e2b.dev pour obtenir votre clé API",
+ "e2bApiKeyRequired": "Une clé API est requise pour activer la fonctionnalité E2B"

src/renderer/src/i18n/fa-IR/settings.json (1)

388-394: Key casing is inconsistent with the rest of the file

Most keys follow camelCase starting with a lower-case letter (e.g. noFoldersSelected).
The newly-added Persian keys start with lower-case except e2bApiKey where the prefix e2b is lower-case and ApiKey is capitalised.
Please align with existing style (e2bApiKey → e2bApiKey is fine) or change all languages consistently (e.g. stick to e2bApiKey) to avoid lookup mistakes in the UI.

src/renderer/src/i18n/zh-HK/settings.json (1)

380-386: Minor translation placeholder typo

e2bApiKeyPlaceholder currently reads 這裡輸入你的E2B Api Keys，如 e2b_1111xx*****.

1. “Keys” plural may confuse users – the backend expects one key.
2. Missing space after E2B.

Consider: 在此輸入你的 E2B API Key，例如 e2b_1111xx*****

src/renderer/src/i18n/ru-RU/settings.json (1)

380-386: Mixed letter-case in new keys

"e2bApiKey" is lower-camelCase while the help string says Apikey.
For consistency and to help translators reuse keys, use the same casing everywhere (APIKey or apiKey, but be consistent across all locales).

src/renderer/src/components/mcp-config/mcpServerForm.vue (2)

595-600: Watcher leaves stale API key when E2B toggle is cleared

When a user unchecks “use E2B”, useE2B becomes false but e2bApiKey retains the previous value.
If the form is re-opened later, the key re-appears although E2B is off.

Option: automatically clear the key when useE2B switches from true→false.

watch(useE2B, checked => {
  if (!checked) e2bApiKey.value = ''
})

---

283-287: Validation ignores leading/trailing whitespace

isE2BConfigValid only checks .trim().length > 0 in the main form check, but the rule itself returns raw .length.
Calling trim() here avoids relying on the outer guard and guarantees consistency.

-  return e2bApiKey.value.trim().length > 0
+  return e2bApiKey.value.trim().length > 0

src/main/presenter/mcpPresenter/inMemoryServers/powerpackServer.ts (6)

55-67: Tighten the E2B input schema.

language is accepted as any string but only 'python' is supported. Restrict via .literal('python') or an enum to surface invalid requests early.

---

88-127: apiKey field is dead-code.

this.apiKey is assigned but never read – static analysis already flags it. Either drop the property or pass it to Sandbox.create({ apiKey }) (if the lib supports) to prevent bit-rot.

---

137-143: env.USE_E2B parsing misses common truthy values.

You treat only true/'true'. Consider also '1', 'yes', etc., or coerce via ['true','1','yes'].includes(String(env.USE_E2B).toLowerCase()) for robustness.

---

212-221: Logging path ignores the “Node only” case.

When both Bun and E2B are absent but Node exists, the warning message triggers before the later console.info. Move the “no runtime” branch after E2B/Node/Bun checks to avoid mixed logs.

---

223-234: Race-condition when multiple calls initialise E2B.

initialize() has a cheap early-exit but two concurrent startServer calls could both pass the isInitialized() check before either sets initialized. Guard with a mutex/Promise cache for certainty.

---

543-566: Return early for unsupported tool when E2B off.

You already gate the tool in ListTools, but defensive checks here are good. Consider returning a specific error code (e.g., UNSUPPORTED_TOOL) instead of a generic 400-style message to help the front-end distinguish config vs. execution failures.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/main/presenter/mcpPresenter/inMemoryServers/powerpackServer.ts (2)

318-327: Still unsafe access to stdout / stderr – same issue flagged previously

result.logs.stdout & stderr are dereferenced without checking they exist or are arrays. This reproduces the crash reported in the earlier review.

-      if (result.logs.stdout.length > 0) {
+      if (result.logs?.stdout?.length) {
...
-      if (result.logs.stderr.length > 0) {
+      if (result.logs?.stderr?.length) {

---

292-342: One sandbox per call – heavy cold-start cost

Sandbox.create() is invoked for every request, incurring ~1-2 s cold-start plus billing overhead. Unless you have strong isolation requirements, pooling a single sandbox (with idle-timeout / explicit kill) reduces latency & cost dramatically.
(Flagged in the previous review as well.)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro