Skip to content

Conversation

@hllshiro
Copy link
Collaborator

@hllshiro hllshiro commented Aug 4, 2025

Pull Request Description

Is your feature request related to a problem? Please describe.
The built-in knowledge base file upload icon needs to be optimized, and the operation requires secondary confirmation.

Describe the solution you'd like

  1. Adjust file operation button order: place the file status icon first, followed by the two operation icons.
  2. Add tooltip to the file status icon.
  3. Add secondary confirmation for file delete and re-upload operations.

UI/UX changes for Desktop Application
image
image

Platform Compatibility Notes
Tested on Windows only


Pull Request Description (中文)

你的功能请求是否与某个问题有关?请描述一下。
内置知识库文件上传的图标需要优化,并且操作需二次确认。

请描述你希望的解决方案

  1. 修改文件操作按钮顺序:文件状态icon放在首位,两个操作icon放在后边
  2. 文件状态icon增加toooltip
  3. 文件删除和重新上传操作增加二次确认

桌面应用程序的 UI/UX 更改
image
image

平台兼容性注意事项
仅在windows测试

Summary by CodeRabbit

  • New Features

    • Added confirmation dialogs for re-adding and deleting files in the knowledge base settings, improving user interaction safety.
    • Introduced tooltips for task control buttons and dynamic status messages for file upload states and bulk task controls.
    • Expanded support for localized status labels, dialog messages, and action labels across multiple languages (English, Persian, French, Japanese, Korean, Russian, Simplified Chinese, Traditional Chinese, and Hong Kong Chinese).
  • Style

    • Updated status icon and action button colors for improved visual clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 4, 2025

Walkthrough

This update enhances the file upload and management UI in the knowledge base settings. It introduces confirmation dialogs for file re-add and delete actions, adds descriptive tooltips for bulk task control buttons, and extends localization files across multiple languages with new status labels and dialog messages for file upload and task management.

Changes

Cohort / File(s) Change Summary
Knowledge File Control Tooltips
src/renderer/src/components/settings/KnowledgeFile.vue
Added descriptive tooltip titles to the pause and resume control buttons for bulk task management, using localized strings. No functional changes.
Knowledge File Item Dialogs & UI Refactor
src/renderer/src/components/settings/KnowledgeFileItem.vue
Refactored UI to wrap file re-add and delete actions in confirmation dialogs. Added helper for localized status titles, updated icon colors, and separated status icon from action buttons. Control flow now requires user confirmation before re-adding or deleting files.
English Localization Additions
src/renderer/src/i18n/en-US/settings.json
Added new status labels, confirmation dialog templates, and bulk action labels for file upload/task management. Modified "searchError" by adding a trailing comma.
Persian Localization Additions
src/renderer/src/i18n/fa-IR/settings.json
Added Persian translations for new status labels, confirmation dialogs, and bulk action labels. Modified "searchError" with a trailing comma.
French Localization Additions
src/renderer/src/i18n/fr-FR/settings.json
Added French translations for new status labels, confirmation dialogs, and bulk action labels. Modified "searchError" with a trailing comma.
Japanese Localization Additions
src/renderer/src/i18n/ja-JP/settings.json
Added Japanese translations for new status labels, confirmation dialogs, and bulk action labels. Modified "searchError" with a trailing comma.
Korean Localization Additions
src/renderer/src/i18n/ko-KR/settings.json
Added Korean translations for new status labels, confirmation dialogs, and bulk action labels. Modified "searchError" with a trailing comma.
Russian Localization Additions
src/renderer/src/i18n/ru-RU/settings.json
Added Russian translations for new status labels, confirmation dialogs, and bulk action labels. Modified "searchError" with a trailing comma.
Simplified Chinese Localization Additions
src/renderer/src/i18n/zh-CN/settings.json
Added Simplified Chinese translations for new status labels, confirmation dialogs, and bulk action labels.
Hong Kong Chinese Localization Additions
src/renderer/src/i18n/zh-HK/settings.json
Added Hong Kong Chinese translations for new status labels, confirmation dialogs, and bulk action labels.
Traditional Chinese Localization Additions
src/renderer/src/i18n/zh-TW/settings.json
Added Traditional Chinese translations for new status labels, confirmation dialogs, and bulk action labels.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant KnowledgeFileItem.vue
    participant AlertDialog
    participant FileManager

    User->>KnowledgeFileItem.vue: Click "Re-add" or "Delete" button
    KnowledgeFileItem.vue->>AlertDialog: Show confirmation dialog with file name
    AlertDialog-->>User: User confirms or cancels
    alt User confirms
        AlertDialog->>KnowledgeFileItem.vue: Trigger reAddFile or deleteFile
        KnowledgeFileItem.vue->>FileManager: Perform file action
    else User cancels
        AlertDialog->>KnowledgeFileItem.vue: Close dialog, no action
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A dialog pops, a bunny hops,
Confirm before you drop or swap!
Now tooltips guide with gentle cheer,
In every language, far and near.
Uploads and tasks, all safe and bright—
The knowledge base feels just right!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d5b7f5 and bb71371.

📒 Files selected for processing (2)
  • src/renderer/src/i18n/fr-FR/settings.json (1 hunks)
  • src/renderer/src/i18n/ko-KR/settings.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/renderer/src/i18n/fr-FR/settings.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/i18n/ko-KR/settings.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-check (x64)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8577e5 and 74987fb.

📒 Files selected for processing (11)
  • src/renderer/src/components/settings/KnowledgeFile.vue (1 hunks)
  • src/renderer/src/components/settings/KnowledgeFileItem.vue (4 hunks)
  • src/renderer/src/i18n/en-US/settings.json (1 hunks)
  • src/renderer/src/i18n/fa-IR/settings.json (1 hunks)
  • src/renderer/src/i18n/fr-FR/settings.json (1 hunks)
  • src/renderer/src/i18n/ja-JP/settings.json (1 hunks)
  • src/renderer/src/i18n/ko-KR/settings.json (1 hunks)
  • src/renderer/src/i18n/ru-RU/settings.json (1 hunks)
  • src/renderer/src/i18n/zh-CN/settings.json (1 hunks)
  • src/renderer/src/i18n/zh-HK/settings.json (1 hunks)
  • src/renderer/src/i18n/zh-TW/settings.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
src/renderer/src/**/*

📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

  • src/renderer/src/i18n/ru-RU/settings.json
  • src/renderer/src/i18n/ko-KR/settings.json
  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/i18n/zh-TW/settings.json
  • src/renderer/src/i18n/fr-FR/settings.json
  • src/renderer/src/i18n/zh-CN/settings.json
  • src/renderer/src/components/settings/KnowledgeFile.vue
  • src/renderer/src/i18n/zh-HK/settings.json
  • src/renderer/src/i18n/en-US/settings.json
  • src/renderer/src/i18n/ja-JP/settings.json
  • src/renderer/src/i18n/fa-IR/settings.json
**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Use English for logs and comments

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/src/**/*.vue

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.vue: Use Composition API for all Vue 3 components
Use Tailwind CSS with scoped styles for styling
Organize components by feature in src/renderer/src/
Follow existing component patterns in src/renderer/src/ when creating new UI components
Use Composition API with proper TypeScript typing for new UI components
Implement responsive design with Tailwind CSS for new UI components
Add proper error handling and loading states for new UI components

Use scoped styles to prevent CSS conflicts between components

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/src/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.{ts,tsx,vue}: Use Pinia for frontend state management
Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/**/*.{vue,ts}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
src/renderer/**/*.{ts,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Files:

  • src/renderer/src/components/settings/KnowledgeFileItem.vue
  • src/renderer/src/components/settings/KnowledgeFile.vue
🔇 Additional comments (11)
src/renderer/src/i18n/zh-HK/settings.json (1)

438-451: New keys look consistent – no action required.

Place-holders use {fileName} (preferred), keys are camel-cased, comma placement is valid JSON.
LGTM.

src/renderer/src/i18n/zh-CN/settings.json (1)

424-442: All additions are consistent across languages.

{fileName} placeholder matches the code expectation, and JSON remains syntactically correct.

src/renderer/src/i18n/en-US/settings.json (1)

438-451: Verify which placeholder name the component actually interpolates

The new strings introduce {fileName} (camel-case).
Other locale files added in this PR use {filename} or even language-specific words. A mismatch will surface as the raw token at runtime.

Please grep the Vue components (e.g., KnowledgeFileItem.vue) and ensure the interpolation key matches this spelling. If the component uses filename, update all locale files accordingly; otherwise keep fileName and change the others.

src/renderer/src/components/settings/KnowledgeFile.vue (2)

19-27: LGTM! Excellent accessibility improvement.

The tooltip addition for the resume button enhances user experience by clearly indicating the button's purpose. The implementation correctly uses i18n for internationalization.


28-36: LGTM! Consistent tooltip implementation.

The pause button tooltip follows the same pattern as the resume button, providing clear context for users. Proper use of internationalization ensures multilingual support.

src/renderer/src/i18n/zh-TW/settings.json (1)

438-451: LGTM! Comprehensive localization support.

The new localization keys properly support the enhanced file management UI with:

  • Status labels for upload states
  • Confirmation dialog texts with dynamic placeholders
  • Bulk task control labels matching the tooltip additions

The Traditional Chinese translations are well-structured and follow the existing pattern.

src/renderer/src/components/settings/KnowledgeFileItem.vue (5)

25-50: LGTM! Improved status display with better UX.

The status display enhancements provide better user feedback:

  • Dynamic tooltips show error reasons or localized status messages
  • Softer error color (red-400) is less jarring than the previous red-500
  • Clean separation of status display from action buttons

51-75: LGTM! Excellent safety improvement with confirmation dialog.

The re-add confirmation dialog prevents accidental file re-uploads:

  • Proper use of AlertDialog components
  • Clear internationalized messaging with file name context
  • Maintains consistent UI styling and interaction patterns

77-100: LGTM! Critical safety feature for destructive operations.

The delete confirmation dialog provides essential protection against accidental file deletion:

  • Consistent implementation with the re-add dialog
  • Clear messaging with file name context
  • Proper use of AlertDialog components for destructive actions

113-123: LGTM! Proper import of AlertDialog components.

All necessary AlertDialog components are correctly imported to support the confirmation dialog functionality.


167-181: LGTM! Well-structured helper function.

The getStatusTitle function provides centralized status message logic:

  • Handles all known status states appropriately
  • Includes proper fallback for unknown states
  • Uses consistent i18n key patterns
  • Follows TypeScript best practices

hllshiro and others added 3 commits August 5, 2025 08:57
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
src/renderer/src/i18n/fr-FR/settings.json (1)

440-440: French wording still unnatural for “paused” status

"paused": "Télécharger une pause" is not idiomatic. Previous feedback suggested "Téléchargement en pause", which reads naturally and matches the English source.

-  "paused": "Télécharger une pause",
+  "paused": "Téléchargement en pause",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74987fb and 2dac4a0.

📒 Files selected for processing (3)
  • src/renderer/src/i18n/fa-IR/settings.json (1 hunks)
  • src/renderer/src/i18n/fr-FR/settings.json (1 hunks)
  • src/renderer/src/i18n/ja-JP/settings.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/renderer/src/i18n/ja-JP/settings.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/i18n/fa-IR/settings.json
🧰 Additional context used
📓 Path-based instructions (1)
src/renderer/src/**/*

📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

  • src/renderer/src/i18n/fr-FR/settings.json
🧠 Learnings (15)
📚 Learning: applies to src/renderer/src/i18n/*.json : maintain consistent structure across all translation files...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Maintain consistent structure across all translation files

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/common.json : shared translation keys must be placed in 'src/render...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/common.json : Shared translation keys must be placed in 'src/renderer/src/i18n/common.json'

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/*.json : regularly check for unused translation keys in i18n files...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Regularly check for unused translation keys in i18n files

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/*.json : when adding new translations, add shared keys to 'common.j...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : When adding new translations, add shared keys to 'common.json' and language-specific keys to the respective language file; keep all language files' keys consistent

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/*.json : translation key naming must use dot-separated hierarchy, l...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Translation key naming must use dot-separated hierarchy, lowercase letters, and meaningful descriptive names (e.g., 'common.button.submit')

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/*.json : each language must have a separate json file in 'src/rende...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Each language must have a separate JSON file in 'src/renderer/src/i18n/'

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/i18n/*.json : language files must be located in 'src/renderer/src/i18n/'...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Language files must be located in 'src/renderer/src/i18n/' directory

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/**/* : use the 'vue-i18n' framework for all internationalization in the ...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/**/* : Use the 'vue-i18n' framework for all internationalization in the renderer

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to **/*.{ts,tsx,js,jsx,vue} : use english for logs and comments...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/**/* : ensure all user-visible text in the renderer uses the translation...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/**/* : Ensure all user-visible text in the renderer uses the translation system

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/**/*.{ts,tsx,vue} : use descriptive variable names with auxiliary verbs (e.g...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/**/*.{vue} : follow naming pattern: {collection}:{icon-name} for icons....
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Follow naming pattern: {collection}:{icon-name} for icons.

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/src/**/* : all user-facing strings must use i18n keys (avoid hardcoded user-...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/**/* : All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/components/**/*.vue : use pascalcase for component names (e.g., authwizard.v...
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/components/**/*.vue : Use PascalCase for component names (e.g., AuthWizard.vue).

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
📚 Learning: applies to src/renderer/**/*.{vue} : prefer "lucide:" icon family as the primary choice....
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Prefer "lucide:" icon family as the primary choice.

Applied to files:

  • src/renderer/src/i18n/fr-FR/settings.json
🪛 Biome (2.1.2)
src/renderer/src/i18n/fr-FR/settings.json

[error] 453-453: Minus must be followed by a digit

(parse)

🪛 GitHub Actions: PR Check
src/renderer/src/i18n/fr-FR/settings.json

[error] 444-444: Prettier formatting check failed due to JSON syntax error: Unexpected token at line 444. The file contains invalid JSON syntax that must be fixed.

🔇 Additional comments (1)
src/renderer/src/i18n/fr-FR/settings.json (1)

447-451: Same issue: diff markers left inside “deleteFile” block

The - / + prefixes here also invalidate the JSON:

   "deleteFile": {
     "title": "Supprimer la confirmation du fichier",
-      "content": "Êtes-vous sûr de supprimer le fichier \"{nom de fichier}\"? Cette opération n'est pas restaurée."
+      "content": "Êtes-vous sûr de vouloir supprimer le fichier \"{fileName}\" ? Cette action est irréversible."
   },

Clean the lines so only the final, + version remains (without the +).

⛔ Skipped due to learnings
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Maintain consistent structure across all translation files
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : Regularly check for unused translation keys in i18n files
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/i18n/*.json : When adding new translations, add shared keys to 'common.json' and language-specific keys to the respective language file; keep all language files' keys consistent

hllshiro and others added 3 commits August 5, 2025 09:01
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@zerob13 zerob13 merged commit 4e1e276 into ThinkInAIXYZ:dev Aug 5, 2025
2 checks passed
zerob13 added a commit that referenced this pull request Aug 6, 2025
* fix: prevent tooltip from overlapping HTML preview in ArtifactDialog (#683)

* fix: unwatch is not a function error in knowledge settings components (#684)

* fix: resolve message editing and markdown rendering issues (#685)

* docs: update Electron-Vite link format to full URL (#687)

* fix: built-in knowledge settings not loaded when first entering (#688)

* fix: enhance lifecycle management by adding unmounted hook and MCP state watcher

* fix: improve knowledge destruction confirmation and enhance unwatch handling in settings

* fix: resolve database lock issue in data reset functionality (#689)

* feat: implement provider-based request rate limit (#686)

* feat: implement provider-based request rate limit

* feat: add input validation with confirmation dialog

* refactor: merge RateLimitPresenter into LLMProviderPresenter

* Optimize/builtin knowledge interaction (#690)

* feat: improve builtInKnowledge file icon style

* feat: add builtInKnowledge resume icon tooltip

* feat: format code

* Update src/renderer/src/i18n/fa-IR/settings.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update src/renderer/src/i18n/ja-JP/settings.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update src/renderer/src/i18n/fr-FR/settings.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update settings.json

* Update src/renderer/src/i18n/fr-FR/settings.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: Fix French and Korean translations for pause and delete file confirmation messages

---------

Co-authored-by: sqsyli <sqsyli@qq.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: fixed dirty data problems (#691)

fixed the old session tool error caused by
fixed the problem that the tool list was not reset when creating a new session

* feat: add mentions support in deeplink (#692)

* feat: add mentions support in chat input and store

* style: format imports and clean up code for better readability

* fix: improve mentions handling in handleStart method

* fix: prompt attach files (#695)

* fix: update file icon handling and improve file upload process

* fix: remove redundant FileItem interface definition in PromptSetting.vue

* fix: implement confirmation dialog for prompt deletion in PromptSetting.vue

* fix: streamline file upload process by removing redundant file content reading logic

* feat: add npm registry caching and optimization system (#697)

* fix: resolve input focus loss issue after sending messages (#694)

* fix: resolve deeplink message not displaying when triggered from settings page (#699)

* fix: update current tools assignment to include tool names when MCP tools are not enabled (#698)

* feat: add support for new models  (#700)

* chore: update ollama model settings

* chore: add support for gpt-oss

* chore: bump to 0.2.9

* fix: refine #698 (#701)

* fix: update current tools assignment to include tool names when MCP tools are not enabled

* fix: update enabled MCP tools assignment to include tool names on session switch

* feat: add Claude Opus 4.1 support and fix anthropic model list dialog (#702)

---------

Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com>
Co-authored-by: cycleccc <2991205548@qq.com>
Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com>
Co-authored-by: sqsyli <sqsyli@qq.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants