fix: built-in knowledge settings not loaded when first entering #688

hllshiro · 2025-08-04T06:16:56Z

Pull Request Description (中文)

你的功能请求是否与某个问题有关？请描述一下。
请对问题进行清晰扼要的描述。
#551 [BUG] 首次打开知识库时配置丢失

请描述你希望的解决方案
请对你希望实现的效果进行清晰扼要的描述。
#599 内置知识库功能在当时未提交，此处修改被遗漏，现已补充

桌面应用程序的 UI/UX 更改
如果此 PR 引入了 UI/UX 更改，请详细描述它们。

如果适用，请包含屏幕截图或 GIF 以直观地演示更改。
解释 UI/UX 决策背后的原因，以及它们如何改善桌面应用程序的用户体验。
无

平台兼容性注意事项
如果此 PR 具有特定的平台兼容性考虑因素（Windows、macOS、Linux），请在此处描述。

是否有任何平台特定的行为或代码调整？无
你是否已在所有相关平台上进行过测试？无

Summary by CodeRabbit

Bug Fixes
- Improved loading timing for builtin knowledge configuration, ensuring it only loads when the system is ready.
- Resolved potential issues with repeated loading and memory leaks by cleaning up watchers properly.
- Enhanced handling of server toggling when MCP is disabled.

…ate watcher

coderabbitai · 2025-08-04T06:17:02Z

Walkthrough

The code refactors the loading of the builtin knowledge configuration in the settings component. Instead of loading on mount, it now watches for the MCP config readiness and triggers loading only when ready. It also adds cleanup for watchers on unmount and manages the builtin knowledge server state based on MCP enablement. Additionally, JSDoc comments were adjusted in the knowledge presenter to clarify method documentation.

Changes

Cohort / File(s)	Change Summary
Settings Component Lifecycle & Watchers `src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue`	Replaces immediate config loading on mount with a watcher on `mcpStore.config.ready`, adds cleanup on unmount, and manages builtin knowledge server state based on MCP enablement.
Knowledge Presenter JSDoc Updates `src/main/presenter/knowledgePresenter/index.ts`	Moves JSDoc comment from `destroy` method to `beforeDestroy` method without changing implementation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant VueComponent
    participant MCPStore

    User->>VueComponent: Component mounts
    VueComponent->>MCPStore: Watch mcpStore.config.ready
    MCPStore-->>VueComponent: config.ready becomes true
    VueComponent->>VueComponent: Call loadBuiltinConfigFromMcp()
    VueComponent->>VueComponent: Stop watcher

    MCPStore-->>VueComponent: mcpStore.mcpEnabled changes
    VueComponent->>VueComponent: If MCP disabled, turn off builtinKnowledge server

    User->>VueComponent: Component unmounts
    VueComponent->>VueComponent: Cleanup watcher

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

fixed: the mcpServer you need maybe undefined when you want to use #601: Both PRs refactor component lifecycle management for MCP config loading, using watchers and unmount cleanup in the same component.

Suggested reviewers

zerob13

Poem

A watcher waits, so calm and keen,
For MCP’s config to be seen.
When ready, loading starts its dance,
And cleans itself at unmount’s chance.
With tidy code and timing right,
The settings page now feels so light—
A bunny hops in pure delight! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9543d62 and 206284b.

📒 Files selected for processing (2)

src/main/presenter/knowledgePresenter/index.ts (1 hunks)
src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/main/presenter/knowledgePresenter/index.ts

🚧 Files skipped from review as they are similar to previous changes (1)

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (1)
888-907: Improve watcher scope and ensure initial trigger

Your approach correctly waits for mcpStore.config.ready before loading the builtin config and cleans up afterward. To tighten this up:

• Move unwatch into the onMounted block so it’s scoped where it’s used
• Add the immediate: true option to guarantee the watcher fires if ready is already true

Suggested diff:
 onMounted(() => {
-  let unwatch: () => void // declared too early
+  let unwatch: () => void
   unwatch = watch(
     () => mcpStore.config.ready,
     async (ready) => {
       if (ready) {
         unwatch() // only run once
         await loadBuiltinConfigFromMcp()
       }
     }
-  )
+  , { immediate: true })
 })
Please verify that the watcher indeed fires on mount when mcpStore.config.ready is already true.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c542c8 and 9543d62.

📒 Files selected for processing (1)

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Use English for logs and comments

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/src/**/*.vue

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.vue: Use Composition API for all Vue 3 components
Use Tailwind CSS with scoped styles for styling
Organize components by feature in src/renderer/src/
Follow existing component patterns in src/renderer/src/ when creating new UI components
Use Composition API with proper TypeScript typing for new UI components
Implement responsive design with Tailwind CSS for new UI components
Add proper error handling and loading states for new UI components

Use scoped styles to prevent CSS conflicts between components

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/src/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.{ts,tsx,vue}: Use Pinia for frontend state management
Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/src/**/*

📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/**/*.{vue,ts}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

src/renderer/**/*.{ts,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

🧠 Learnings (18)

📚 Learning: applies to src/renderer/**/*.{vue} : use <script setup> syntax for concise component definitions....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use <script setup> syntax for concise component definitions.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : leverage ref, reactive, and computed for reactive state managem...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Leverage ref, reactive, and computed for reactive state management.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : leverage vue's built-in reactivity system for...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Leverage Vue's built-in reactivity system for efficient data handling

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use composition api and declarative programming patterns; avoid...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : implement proper state persistence for...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/pinia-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:03.479Z
Learning: Applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : Implement proper state persistence for maintaining data across sessions

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : use the composition api for better code organ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Use the Composition API for better code organization and reusability

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.vue : add proper error handling and loading states for new ui compo...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Add proper error handling and loading states for new UI components

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : keep the store focused on global state...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/pinia-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:03.479Z
Learning: Applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : Keep the store focused on global state, not component-specific data

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : import icon component from iconify/vue....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Import Icon component from Iconify/Vue.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use iconify/vue for icon implementation....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use Iconify/Vue for icon implementation.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use the icon component with lucide icons....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use the Icon component with lucide icons.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.vue : use composition api with proper typescript typing for new ui ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Use Composition API with proper TypeScript typing for new UI components

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : for cases where lucide icons don't meet requirements, use other...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : For cases where lucide icons don't meet requirements, use other Iconify collections as fallback.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: utilize nuxt's auto-imports feature for components and composables....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Utilize Nuxt's auto-imports feature for components and composables.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/* : use the 'vue-i18n' framework for all internationalization in the ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/i18n.mdc:0-0
Timestamp: 2025-07-21T01:46:30.354Z
Learning: Applies to src/renderer/src/**/* : Use the 'vue-i18n' framework for all internationalization in the renderer

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : utilize vue router for navigation and route m...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Utilize Vue Router for navigation and route management

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: in vue router setup (src/renderer/src/router/), route-level code splitting should be implemented to ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-router-best-practices.mdc:0-0
Timestamp: 2025-06-23T13:06:06.476Z
Learning: In Vue Router setup (src/renderer/src/router/), route-level code splitting should be implemented to enhance application performance.

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

📚 Learning: applies to src/main/presenter/mcppresenter/index.ts : register new mcp tool in mcppresenter/index.ts...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Applied to files:

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build-check (x64)

🔇 Additional comments (3)

src/renderer/src/components/settings/BuiltinKnowledgeSettings.vue (3)

489-489: LGTM!

The addition of onUnmounted import is necessary for the cleanup functionality and follows the existing import pattern.

878-886: LGTM!

The watcher ensures proper state consistency by automatically disabling the builtin knowledge server when MCP is globally disabled. The logic correctly checks the current state before toggling to avoid unnecessary operations.

488-907: Excellent solution that addresses the core issue.

The refactored lifecycle management successfully solves the problem described in the PR objectives. The changes:

✅ Solve the stated problem: Builtin knowledge settings now load correctly by waiting for MCP config readiness
✅ Follow coding guidelines: Proper use of Composition API, TypeScript, and Vue 3 patterns
✅ Implement proper cleanup: Prevents memory leaks with onUnmounted hook
✅ Maintain state consistency: New watcher ensures server state aligns with global MCP state
✅ Minimal and focused: Changes are precisely targeted to the issue without unnecessary complexity

The implementation demonstrates good understanding of Vue 3 reactivity and lifecycle management.

…andling in settings

* fix: prevent tooltip from overlapping HTML preview in ArtifactDialog (#683) * fix: unwatch is not a function error in knowledge settings components (#684) * fix: resolve message editing and markdown rendering issues (#685) * docs: update Electron-Vite link format to full URL (#687) * fix: built-in knowledge settings not loaded when first entering (#688) * fix: enhance lifecycle management by adding unmounted hook and MCP state watcher * fix: improve knowledge destruction confirmation and enhance unwatch handling in settings * fix: resolve database lock issue in data reset functionality (#689) * feat: implement provider-based request rate limit (#686) * feat: implement provider-based request rate limit * feat: add input validation with confirmation dialog * refactor: merge RateLimitPresenter into LLMProviderPresenter * Optimize/builtin knowledge interaction (#690) * feat: improve builtInKnowledge file icon style * feat: add builtInKnowledge resume icon tooltip * feat: format code * Update src/renderer/src/i18n/fa-IR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/i18n/ja-JP/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/i18n/fr-FR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update settings.json * Update src/renderer/src/i18n/fr-FR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Fix French and Korean translations for pause and delete file confirmation messages --------- Co-authored-by: sqsyli <sqsyli@qq.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: fixed dirty data problems (#691) fixed the old session tool error caused by fixed the problem that the tool list was not reset when creating a new session * feat: add mentions support in deeplink (#692) * feat: add mentions support in chat input and store * style: format imports and clean up code for better readability * fix: improve mentions handling in handleStart method * fix: prompt attach files (#695) * fix: update file icon handling and improve file upload process * fix: remove redundant FileItem interface definition in PromptSetting.vue * fix: implement confirmation dialog for prompt deletion in PromptSetting.vue * fix: streamline file upload process by removing redundant file content reading logic * feat: add npm registry caching and optimization system (#697) * fix: resolve input focus loss issue after sending messages (#694) * fix: resolve deeplink message not displaying when triggered from settings page (#699) * fix: update current tools assignment to include tool names when MCP tools are not enabled (#698) * feat: add support for new models (#700) * chore: update ollama model settings * chore: add support for gpt-oss * chore: bump to 0.2.9 * fix: refine #698 (#701) * fix: update current tools assignment to include tool names when MCP tools are not enabled * fix: update enabled MCP tools assignment to include tool names on session switch * feat: add Claude Opus 4.1 support and fix anthropic model list dialog (#702) --------- Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: cycleccc <2991205548@qq.com> Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: sqsyli <sqsyli@qq.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix: enhance lifecycle management by adding unmounted hook and MCP st…

9543d62

…ate watcher

coderabbitai bot reviewed Aug 4, 2025

View reviewed changes

fix: improve knowledge destruction confirmation and enhance unwatch h…

206284b

…andling in settings

zerob13 approved these changes Aug 4, 2025

View reviewed changes

zerob13 merged commit 4e15ff8 into ThinkInAIXYZ:dev Aug 4, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: built-in knowledge settings not loaded when first entering #688

fix: built-in knowledge settings not loaded when first entering #688

Uh oh!

hllshiro commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: built-in knowledge settings not loaded when first entering #688

fix: built-in knowledge settings not loaded when first entering #688

Uh oh!

Conversation

hllshiro commented Aug 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description (中文)

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hllshiro commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)