fix: unwatch is not a function error in knowledge settings components #684

yyhhyyyyyy · 2025-08-03T07:59:00Z

fix unwatch is not a function error in knowledge settings components

Summary by CodeRabbit

Bug Fixes
- Improved stability and prevented potential errors in knowledge settings by ensuring watcher cleanup functions are safely invoked only when defined. This enhances reliability when changing or unmounting settings components.

coderabbitai · 2025-08-03T07:59:06Z

Walkthrough

The changes update the type and invocation of the unwatch cleanup function in three Vue component files. The unwatch variable is now nullable, and its calls are guarded using optional chaining (unwatch?.()) to prevent errors if it is undefined. This adjustment is applied in watcher callbacks and onUnmounted hooks.

Changes

Cohort / File(s)	Change Summary
Knowledge Settings Components – unwatch Type and Invocation `src/renderer/src/components/settings/DifyKnowledgeSettings.vue`, `src/renderer/src/components/settings/FastGptKnowledgeSettings.vue`, `src/renderer/src/components/settings/RagflowKnowledgeSettings.vue`	Changed the `unwatch` variable from a non-nullable function to a nullable function type (`(() => void) \| undefined`), and updated all invocations to use optional chaining (`unwatch?.()`) in watcher callbacks and cleanup.

Sequence Diagram(s)

sequenceDiagram
    participant Component
    participant Watcher
    participant Lifecycle

    Component->>Watcher: Set up watcher, assign cleanup to unwatch
    Watcher->>Component: On trigger, call unwatch?.()
    Lifecycle->>Component: onUnmounted hook
    Component->>Watcher: Call unwatch?.() for cleanup

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

fixed: the mcpServer you need maybe undefined when you want to use #601: Also modifies watcher setup and cleanup logic in the same components, introducing watcher registration and unregistration in lifecycle hooks.

Suggested reviewers

zerob13

Poem

A watcher’s work is never done,
Unless unwatching’s safely spun.
With nullable care and optional call,
No runtime errors shall befall.
In settings deep, the cleanup’s neat—
This bunny’s code is now complete! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3a4d89 and da98cf8.

📒 Files selected for processing (3)

src/renderer/src/components/settings/DifyKnowledgeSettings.vue (2 hunks)
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue (2 hunks)
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Use English for logs and comments

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/src/**/*.vue

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.vue: Use Composition API for all Vue 3 components
Use Tailwind CSS with scoped styles for styling
Organize components by feature in src/renderer/src/
Follow existing component patterns in src/renderer/src/ when creating new UI components
Use Composition API with proper TypeScript typing for new UI components
Implement responsive design with Tailwind CSS for new UI components
Add proper error handling and loading states for new UI components

Use scoped styles to prevent CSS conflicts between components

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/src/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.{ts,tsx,vue}: Use Pinia for frontend state management
Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/src/**/*

📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/**/*.{vue,ts}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

src/renderer/**/*.{ts,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

🧠 Learnings (15)

📓 Common learnings

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Leverage ref, reactive, and computed for reactive state management.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Leverage Vue's built-in reactivity system for efficient data handling

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Use Composition API with proper TypeScript typing for new UI components

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Add proper error handling and loading states for new UI components

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use Vue 3 with TypeScript, leveraging defineComponent and PropType.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Use the Composition API for better code organization and reusability

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use arrow functions for methods and computed properties.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Use Composition API for all Vue 3 components

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use <script setup> syntax for concise component definitions.

📚 Learning: applies to src/renderer/**/*.{vue} : use composition api and declarative programming patterns; avoid...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.vue : use composition api with proper typescript typing for new ui ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Use Composition API with proper TypeScript typing for new UI components

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use vue 3 with typescript, leveraging definecomponent and propt...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use Vue 3 with TypeScript, leveraging defineComponent and PropType.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{ts,tsx,vue} : use arrow functions for methods and computed properties....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use arrow functions for methods and computed properties.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : leverage ref, reactive, and computed for reactive state managem...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Leverage ref, reactive, and computed for reactive state management.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use <script setup> syntax for concise component definitions....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use <script setup> syntax for concise component definitions.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : leverage vue's built-in reactivity system for...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Leverage Vue's built-in reactivity system for efficient data handling

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : use the composition api for better code organ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.817Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Use the Composition API for better code organization and reusability

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue
src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use provide/inject for dependency injection when appropriate....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use provide/inject for dependency injection when appropriate.

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : implement proper state persistence for...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/pinia-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:03.479Z
Learning: Applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : Implement proper state persistence for maintaining data across sessions

Applied to files:

src/renderer/src/components/settings/DifyKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : use getters for computed state propert...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/pinia-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:03.479Z
Learning: Applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : Use getters for computed state properties

Applied to files:

src/renderer/src/components/settings/FastGptKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : optimize images: use webp format, include size data, implement ...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Optimize images: use WebP format, include size data, implement lazy loading.

Applied to files:

src/renderer/src/components/settings/FastGptKnowledgeSettings.vue

📚 Learning: applies to src/renderer/src/**/*.vue : add proper error handling and loading states for new ui compo...

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.790Z
Learning: Applies to src/renderer/src/**/*.vue : Add proper error handling and loading states for new UI components

Applied to files:

src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

📚 Learning: applies to src/renderer/**/*.{vue} : use template syntax for declarative rendering....

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use template syntax for declarative rendering.

Applied to files:

src/renderer/src/components/settings/RagflowKnowledgeSettings.vue

🔇 Additional comments (6)

src/renderer/src/components/settings/DifyKnowledgeSettings.vue (2)

421-421: LGTM! Proper nullable typing for watcher cleanup function.

The type declaration correctly allows unwatch to be undefined, which prevents the runtime error described in the PR objectives.

427-427: LGTM! Safe optional chaining prevents runtime errors.

Using optional chaining (?.) consistently ensures the cleanup function is only called when defined, effectively resolving the "unwatch is not a function" error. The approach is defensive and follows best practices for handling potentially undefined function references.

Also applies to: 437-437

src/renderer/src/components/settings/FastGptKnowledgeSettings.vue (2)

420-420: LGTM! Consistent nullable typing across knowledge components.

The type declaration matches the pattern established in other knowledge settings components, ensuring consistent handling of the watcher cleanup function.

426-426: LGTM! Consistent optional chaining implementation.

The optional chaining usage is identical to the other knowledge settings components, demonstrating good consistency in the fix application across the codebase.

Also applies to: 436-436

src/renderer/src/components/settings/RagflowKnowledgeSettings.vue (2)

438-438: LGTM! Completes consistent nullable typing pattern.

The type declaration completes the consistent fix pattern across all three knowledge settings components (Dify, FastGPT, and RAGFlow).

444-444: LGTM! Completes the comprehensive fix across all components.

The optional chaining usage completes the consistent implementation across all knowledge settings components, ensuring the "unwatch is not a function" error is resolved throughout the knowledge settings functionality.

Also applies to: 454-454

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* fix: prevent tooltip from overlapping HTML preview in ArtifactDialog (#683) * fix: unwatch is not a function error in knowledge settings components (#684) * fix: resolve message editing and markdown rendering issues (#685) * docs: update Electron-Vite link format to full URL (#687) * fix: built-in knowledge settings not loaded when first entering (#688) * fix: enhance lifecycle management by adding unmounted hook and MCP state watcher * fix: improve knowledge destruction confirmation and enhance unwatch handling in settings * fix: resolve database lock issue in data reset functionality (#689) * feat: implement provider-based request rate limit (#686) * feat: implement provider-based request rate limit * feat: add input validation with confirmation dialog * refactor: merge RateLimitPresenter into LLMProviderPresenter * Optimize/builtin knowledge interaction (#690) * feat: improve builtInKnowledge file icon style * feat: add builtInKnowledge resume icon tooltip * feat: format code * Update src/renderer/src/i18n/fa-IR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/i18n/ja-JP/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/i18n/fr-FR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update settings.json * Update src/renderer/src/i18n/fr-FR/settings.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Fix French and Korean translations for pause and delete file confirmation messages --------- Co-authored-by: sqsyli <sqsyli@qq.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: fixed dirty data problems (#691) fixed the old session tool error caused by fixed the problem that the tool list was not reset when creating a new session * feat: add mentions support in deeplink (#692) * feat: add mentions support in chat input and store * style: format imports and clean up code for better readability * fix: improve mentions handling in handleStart method * fix: prompt attach files (#695) * fix: update file icon handling and improve file upload process * fix: remove redundant FileItem interface definition in PromptSetting.vue * fix: implement confirmation dialog for prompt deletion in PromptSetting.vue * fix: streamline file upload process by removing redundant file content reading logic * feat: add npm registry caching and optimization system (#697) * fix: resolve input focus loss issue after sending messages (#694) * fix: resolve deeplink message not displaying when triggered from settings page (#699) * fix: update current tools assignment to include tool names when MCP tools are not enabled (#698) * feat: add support for new models (#700) * chore: update ollama model settings * chore: add support for gpt-oss * chore: bump to 0.2.9 * fix: refine #698 (#701) * fix: update current tools assignment to include tool names when MCP tools are not enabled * fix: update enabled MCP tools assignment to include tool names on session switch * feat: add Claude Opus 4.1 support and fix anthropic model list dialog (#702) --------- Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: cycleccc <2991205548@qq.com> Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: sqsyli <sqsyli@qq.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix: unwatch is not a function error in knowledge settings components

da98cf8

zerob13 approved these changes Aug 3, 2025

View reviewed changes

zerob13 merged commit 7aba33f into ThinkInAIXYZ:dev Aug 3, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: unwatch is not a function error in knowledge settings components #684

fix: unwatch is not a function error in knowledge settings components #684

Uh oh!

yyhhyyyyyy commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: unwatch is not a function error in knowledge settings components #684

fix: unwatch is not a function error in knowledge settings components #684

Uh oh!

Conversation

yyhhyyyyyy commented Aug 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yyhhyyyyyy commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)