Conversation
| using: composite | ||
| steps: | ||
| - name: Install Rust toolchain and components | ||
| uses: dtolnay/rust-toolchain@master |
There was a problem hiding this comment.
What happens if the user's workflow already includes this step beforehand? Nothing or does it break?
There was a problem hiding this comment.
It installs this toolchain alongside the one they previously installed. It also runs rustup default, which is unfortunately not something that can be disabled, so the new nightly-2025-XX-XX toolchain will be made the default.
| will be available through the `PATH` by default. | ||
|
|
||
| Note that this currently will override the default Rustup toolchain to nightly. You can fix this | ||
| by calling `rustup default` after this action is run. |
There was a problem hiding this comment.
Should we integrate rustup default directly in this script? Or are there scenarios where you don't want to use it?
There was a problem hiding this comment.
We don't need rustup default, since we always manually specify which toolchain should be used. Although we could use it to revert this behavior...
There was a problem hiding this comment.
I tried to make the action restore the original default toolchain, but my first attempt didn't work. I'm going to leave this to a follow-up issue.
There was a problem hiding this comment.
Have you considered not using the action, instead requiring that rustup and cargo are already installed and then manually installing the required toolchain via the rustup command?
But that can indeed be done in a follow-up :)
There was a problem hiding this comment.
Interesting! That does sound a lot nicer, although it would mean ditching dtolnay/rust-toolchain since it's just not configurable enough to install Rustup without a specific toolchain. I think it's worth considering, but definitely later
TimJentzsch
left a comment
There was a problem hiding this comment.
Already good for the first iteration, we can refine it further as we go :)
| will be available through the `PATH` by default. | ||
|
|
||
| Note that this currently will override the default Rustup toolchain to nightly. You can fix this | ||
| by calling `rustup default` after this action is run. |
There was a problem hiding this comment.
Have you considered not using the action, instead requiring that rustup and cargo are already installed and then manually installing the required toolchain via the rustup command?
But that can indeed be done in a follow-up :)
This PR prepares `bevy_lint` for v0.3.0, following the [release guide](https://github.com/TheBevyFlock/bevy_cli/blob/e85154b9bd5851a0dcac3815853ec8194d362fb3/bevy_lint/docs/how-to/release.md). Once this is marked ready for review, this will need at least one approval from a Bevy maintainer and no outstanding concerns. Once this is merged, a feature freeze will be enacted until the [post-release PR is merged](https://github.com/TheBevyFlock/bevy_cli/blob/e85154b9bd5851a0dcac3815853ec8194d362fb3/bevy_lint/docs/how-to/release.md#post-release). ## Blockers - [x] #380 - [x] #389 - [x] #391 ## For Reviewers Now is your chance to look through the [docs](https://thebevyflock.github.io/bevy_cli/bevy_lint/index.html), the changelog, and the migration guide to ensure everything is in working order. If you wish to test the linter, you may install it from this branch: ```sh rustup toolchain install nightly-2025-04-03 \ --component rustc-dev \ --component llvm-tools-preview rustup run nightly-2025-04-03 cargo install \ --git https://github.com/TheBevyFlock/bevy_cli.git \ --branch linter-v0.3.0 \ --locked \ bevy_lint ``` You're encouraged to run the linter on several projects to ensure it works correctly. Some good places to start include: - [The Engine](https://github.com/bevyengine/bevy) - [`bevy_new_2d`](https://github.com/TheBevyFlock/bevy_new_2d) - [The Official Template](https://github.com/bevyengine/bevy_github_ci_template) Thank you for all of your help! ## Next Steps - Release on Github - Announce the release on Discord, Mastodon, and other social medias - Potentially publish an announcement [blog post](https://bd103.github.io/) - TheBevyFlock/bevy_new_2d#365 --------- Co-authored-by: DAA <42379074+DaAlbrecht@users.noreply.github.com>
This PR adds support for installing
bevy_lintin CI. (Motivated by TheBevyFlock/bevy_new_2d#365, caused dtolnay/rust-toolchain#144.)In the process, I also wrote a workflow to test the action. I also plan on updating the docs and contributing guide for this feature.