Allow disabling rustup default step#144
Closed
BD103 wants to merge 3 commits intodtolnay:masterfrom
BD103:make-default
Closed
Allow disabling rustup default step#144BD103 wants to merge 3 commits intodtolnay:masterfrom BD103:make-default
rustup default step#144BD103 wants to merge 3 commits intodtolnay:masterfrom
BD103:make-default
Conversation
They're just extra confusing, and we already specify it must be a string.
dtolnay
reviewed
Apr 22, 2025
Owner
dtolnay
left a comment
There was a problem hiding this comment.
Thanks for the PR, but I would prefer not to support customizing this. You should use a fork or a different action.
BD103
added a commit
to TheBevyFlock/bevy_cli
that referenced
this pull request
Apr 22, 2025
Author
That's disappointing, but I understand. Thank you for considering this anyways! |
BD103
added a commit
to TheBevyFlock/bevy_cli
that referenced
this pull request
Apr 25, 2025
This PR adds support for installing `bevy_lint` in CI. (Motivated by TheBevyFlock/bevy_new_2d#365, caused dtolnay/rust-toolchain#144.) ```yml - name: Install `bevy_lint` uses: TheBevyFlock/bevy_cli/bevy_lint@main - name: Run `bevy_lint` run: bevy_lint --workspace ``` In the process, I also wrote a workflow to test the action. I also plan on updating the docs and contributing guide for this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm writing an action that needs a specific Rustup nightly toolchain, but I do not want to override the default toolchain installed by users of my action (which is usually stable or a different nightly version). This PR adds a new
make-defaultinput (feel free to change the name) that allows you to configure whetherrustup defaultis run:make-defaultistrueby default, meaning the original behavior is kept. (It's not a breaking change!)make-defaultsupports the valuestrueorfalse, though the string forms of'true'or"true"also work. (Within the action,make-defaultis coerced to a string and then compared with== 'true'.)I've tested my changes using this workflow, which I've run here.
Thank you!