Mark plugin_not_ending_in_plugin as a renamed lint#391
Merged
DaAlbrecht merged 1 commit intomainfrom Apr 25, 2025
Merged
Conversation
…deleting it This provides easier migration to the new lint.
BD103
added a commit
that referenced
this pull request
Apr 30, 2025
This PR prepares `bevy_lint` for v0.3.0, following the [release guide](https://github.com/TheBevyFlock/bevy_cli/blob/e85154b9bd5851a0dcac3815853ec8194d362fb3/bevy_lint/docs/how-to/release.md). Once this is marked ready for review, this will need at least one approval from a Bevy maintainer and no outstanding concerns. Once this is merged, a feature freeze will be enacted until the [post-release PR is merged](https://github.com/TheBevyFlock/bevy_cli/blob/e85154b9bd5851a0dcac3815853ec8194d362fb3/bevy_lint/docs/how-to/release.md#post-release). ## Blockers - [x] #380 - [x] #389 - [x] #391 ## For Reviewers Now is your chance to look through the [docs](https://thebevyflock.github.io/bevy_cli/bevy_lint/index.html), the changelog, and the migration guide to ensure everything is in working order. If you wish to test the linter, you may install it from this branch: ```sh rustup toolchain install nightly-2025-04-03 \ --component rustc-dev \ --component llvm-tools-preview rustup run nightly-2025-04-03 cargo install \ --git https://github.com/TheBevyFlock/bevy_cli.git \ --branch linter-v0.3.0 \ --locked \ bevy_lint ``` You're encouraged to run the linter on several projects to ensure it works correctly. Some good places to start include: - [The Engine](https://github.com/bevyengine/bevy) - [`bevy_new_2d`](https://github.com/TheBevyFlock/bevy_new_2d) - [The Official Template](https://github.com/bevyengine/bevy_github_ci_template) Thank you for all of your help! ## Next Steps - Release on Github - Announce the release on Discord, Mastodon, and other social medias - Potentially publish an announcement [blog post](https://bd103.github.io/) - TheBevyFlock/bevy_new_2d#365 --------- Co-authored-by: DAA <42379074+DaAlbrecht@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LintStore::register_renamed()provides an easy method for migrating fromplugin_not_ending_in_plugintounconventional_naming. If the linter ever runs into code referencingplugin_not_ending_in_plugin:#![warn(bevy::plugin_not_ending_in_plugin)]It will now emit a warning that the lint has been renamed, but still correctly configure
unconventional_naming:Since all of
plugin_not_ending_in_pluginwas merged intounconventional_naming, this proposes we market it as a rename instead of a complete removal.