Skip to content

[UPMERGE] 2.0 -> 2.0-docs#17842

Merged
GSadee merged 33 commits into2.0-docsfrom
upmerge/2.0_2.0-docs
Apr 8, 2025
Merged

[UPMERGE] 2.0 -> 2.0-docs#17842
GSadee merged 33 commits into2.0-docsfrom
upmerge/2.0_2.0-docs

Conversation

@SyliusBot
Copy link
Copy Markdown
Contributor

This PR has been generated automatically.
For more details see upmerge_pr.yaml.

Remember! The upmerge should always be merged with using Merge pull request button.

In case of conflicts, please resolve them manually with usign the following commands:

git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/2.0-docs -m "Resolve conflicts between 2.0 and 2.0-docs"

If you use other name for the upstream remote, please replace upstream with the name of your remote pointing to the Sylius/Sylius repository.

Once the conflicts are resolved, please run git merge --continue and push the changes to this PR.

Rafikooo and others added 30 commits April 2, 2025 01:32
…en I add` - Promotion & Some other scenarios (#17818)

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

Continuation of:
- #17785
- #17782
- #17783

Until now, the checkout-related scenarios have been set up as follows:
• UI – via web actions (e.g. `Given I have a product ...` actually
triggered browser actions to prepare the initial step),
	•	API – a mix of messenger commands and API calls.

During the development of Sylius 2.0, with the introduction of dynamic
components, all scenarios involving product-related actions had to be
marked as JS to work correctly. This significantly increased build time
and reduced overall stability.

This PR focuses on decoupling the Behat architecture to unify the test
setup for both UI and API. The goal is to eliminate most JS tags, which
should lead to greater stability. Some performance improvements are
already noticeable.


This PR doesn’t yet include all refactored scenarios, but at this stage
we already observe the following performance gains:
• For non-JS scenarios, the timing is likely similar — some JS scenarios
have been converted to non-JS, but at the same time, we benefit from
faster setup thanks to the refactor (using messenger commands instead of
API calls or UI interactions to prepare tests).
• For JS scenarios executed via Chromedriver, the same applies — some
Panther scenarios have been switched to Chromedriver, and performance
remains comparable.

JS with Panther: **~30 min → ~20 min**
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | n/a
| License         | MIT
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | continuation of #17818 and #17819
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.14 or 2.0 branch
 - Features and deprecations must be submitted against the 2.1 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #17819
| License         | MIT
This PR has been generated automatically.
For more details see
[refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Rafikooo and others added 3 commits April 7, 2025 23:31
| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

For some reason, our CI suddenly started failing. It turned out that
there was a small flaw in our UI flow, which this PR addresses.

As part of this proposal, due to the current logic on the offer
page—specifically the dynamic validation of the `Add to cart`
button—some scenarios that rely on this behavior would ideally need to
be rewritten. To avoid that, I introduced a single test that verifies
the actual UI behavior while leaving the remaining tests untouched.

Additionally, I introduced a new ui subpath intended to contain only
pure UI tests. In the future, the plan is to isolate only the most
crucial, individual UI-related cases there while refactoring the
remaining variations into more domain-focused tests.

I’m aware that this approach breaks the BDD principle of specifying
behavior rather than relying on visible UI elements in the scenario
definition; however, since we have some pure UI cases, in my opinion it
is acceptable to use it in such a way.
@SyliusBot SyliusBot requested review from a team as code owners April 8, 2025 05:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@GSadee GSadee merged commit 24d57c3 into 2.0-docs Apr 8, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants