Skip to content

[Behat] Reorder Alphabetically UI & API Suite Configs#17782

Merged
GSadee merged 2 commits intoSylius:2.0from
Rafikooo:SYL-4544/behat-refine-suites-configs
Mar 27, 2025
Merged

[Behat] Reorder Alphabetically UI & API Suite Configs#17782
GSadee merged 2 commits intoSylius:2.0from
Rafikooo:SYL-4544/behat-refine-suites-configs

Conversation

@Rafikooo
Copy link
Copy Markdown
Contributor

@Rafikooo Rafikooo commented Mar 26, 2025

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

I propose this enhancement for consistency and future readability of changes within these config files.

@Rafikooo Rafikooo requested review from a team as code owners March 26, 2025 13:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

Prometee
Prometee previously approved these changes Mar 26, 2025
@Rafikooo Rafikooo force-pushed the SYL-4544/behat-refine-suites-configs branch from d2f459b to ee2a939 Compare March 26, 2025 13:41
@Rafikooo Rafikooo changed the title [Behat] Reorder Alphabetically UI Suite Configs [Behat] Reorder Alphabetically UI & API Suite Configs Mar 26, 2025
@GSadee GSadee added the Behat Issues and PRs aimed at improving Behat usage. label Mar 27, 2025
@GSadee GSadee merged commit d974562 into Sylius:2.0 Mar 27, 2025
27 checks passed
GSadee added a commit that referenced this pull request Mar 27, 2025
…nfiguration management (#17783)

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

Continuation of #17782

This proposal is motivated by the issue in Behat when suite
configuration includes contexts that define the same method.
In brief, this decoupling provides more flexibility in managing suite
configurations.
GSadee added a commit that referenced this pull request Mar 28, 2025
…en I add` (#17785)

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

Continuation of:
- #17782
- #17783

Until now, the checkout-related scenarios have been set up as follows:
• UI – via web actions (e.g. `Given I have a product ...` actually
triggered browser actions to prepare the initial step),
	•	API – a mix of messenger commands and API calls.

During the development of Sylius 2.0, with the introduction of dynamic
components, all scenarios involving product-related actions had to be
marked as JS to work correctly. This significantly increased build time
and reduced overall stability.

This PR focuses on decoupling the Behat architecture to unify the test
setup for both UI and API. The goal is to eliminate most JS tags, which
should lead to greater stability. Some performance improvements are
already noticeable.


This PR doesn’t yet include all refactored scenarios, but at this stage
we already observe the following performance gains:
• For non-JS scenarios, the timing is likely similar — some JS scenarios
have been converted to non-JS, but at the same time, we benefit from
faster setup thanks to the refactor (using messenger commands instead of
API calls or UI interactions to prepare tests).
• For JS scenarios executed via Chromedriver, the same applies — some
Panther scenarios have been switched to Chromedriver, and performance
remains comparable.

JS with Panther: **~30 min → ~20 min**
- sylius.behat.context.setup.taxonomy
- sylius.behat.context.setup.user
- sylius.behat.context.setup.zone

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

GSadee added a commit that referenced this pull request Apr 2, 2025
…en I add` - Promotion & Some other scenarios (#17818)

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

Continuation of:
- #17785
- #17782
- #17783

Until now, the checkout-related scenarios have been set up as follows:
• UI – via web actions (e.g. `Given I have a product ...` actually
triggered browser actions to prepare the initial step),
	•	API – a mix of messenger commands and API calls.

During the development of Sylius 2.0, with the introduction of dynamic
components, all scenarios involving product-related actions had to be
marked as JS to work correctly. This significantly increased build time
and reduced overall stability.

This PR focuses on decoupling the Behat architecture to unify the test
setup for both UI and API. The goal is to eliminate most JS tags, which
should lead to greater stability. Some performance improvements are
already noticeable.


This PR doesn’t yet include all refactored scenarios, but at this stage
we already observe the following performance gains:
• For non-JS scenarios, the timing is likely similar — some JS scenarios
have been converted to non-JS, but at the same time, we benefit from
faster setup thanks to the refactor (using messenger commands instead of
API calls or UI interactions to prepare tests).
• For JS scenarios executed via Chromedriver, the same applies — some
Panther scenarios have been switched to Chromedriver, and performance
remains comparable.

JS with Panther: **~30 min → ~20 min**
GSadee added a commit that referenced this pull request Apr 9, 2025
…` and related scenarios) (#17816)

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| License         | MIT

Continuation of:
- #17785
- #17782
- #17783

Until now, the checkout-related scenarios have been set up as follows:
• UI – via web actions (e.g. `Given I have a product ...` actually
triggered browser actions to prepare the initial step),
	•	API – a mix of messenger commands and API calls.

During the development of Sylius 2.0, with the introduction of dynamic
components, all scenarios involving product-related actions had to be
marked as JS to work correctly. This significantly increased build time
and reduced overall stability.

This PR focuses on decoupling the Behat architecture to unify the test
setup for both UI and API. The goal is to eliminate most JS tags, which
should lead to greater stability. Some performance improvements are
already noticeable.


This PR doesn’t yet include all refactored scenarios, but at this stage
we already observe the following performance gains:
• For non-JS scenarios, the timing is likely similar — some JS scenarios
have been converted to non-JS, but at the same time, we benefit from
faster setup thanks to the refactor (using messenger commands instead of
API calls or UI interactions to prepare tests).
• For JS scenarios executed via Chromedriver, the same applies — some
Panther scenarios have been switched to Chromedriver, and performance
remains comparable.

JS with Panther: **~30 min → ~20 min**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Behat Issues and PRs aimed at improving Behat usage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants