[Behat] Fix adding to cart scenarios#17839
Merged
GSadee merged 3 commits intoSylius:2.0from Apr 8, 2025
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
4ff622c to
36d2989
Compare
36d2989 to
239a362
Compare
mpysiak
approved these changes
Apr 8, 2025
GSadee
approved these changes
Apr 8, 2025
| @@ -0,0 +1,17 @@ | |||
| @shopping_cart | |||
| Feature: Verify Add-to-Cart Button State Validation | |||
Member
There was a problem hiding this comment.
Suggested change
| Feature: Verify Add-to-Cart Button State Validation | |
| Feature: Verifying "Add to cart" button state |
the file name could also be adjusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, our CI suddenly started failing. It turned out that there was a small flaw in our UI flow, which this PR addresses.
As part of this proposal, due to the current logic on the offer page—specifically the dynamic validation of the
Add to cartbutton—some scenarios that rely on this behavior would ideally need to be rewritten. To avoid that, I introduced a single test that verifies the actual UI behavior while leaving the remaining tests untouched.Additionally, I introduced a new ui subpath intended to contain only pure UI tests. In the future, the plan is to isolate only the most crucial, individual UI-related cases there while refactoring the remaining variations into more domain-focused tests.
I’m aware that this approach breaks the BDD principle of specifying behavior rather than relying on visible UI elements in the scenario definition; however, since we have some pure UI cases, in my opinion it is acceptable to use it in such a way.