Skip to content

[Behat][Taxation] Refactor shop scenarios to reduce js tags#17822

Merged
Rafikooo merged 1 commit intoSylius:2.0from
GSadee:SYL-4585-refactor-shop-taxation-scenarios
Apr 2, 2025
Merged

[Behat][Taxation] Refactor shop scenarios to reduce js tags#17822
Rafikooo merged 1 commit intoSylius:2.0from
GSadee:SYL-4585-refactor-shop-taxation-scenarios

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Apr 2, 2025

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets continuation of #17818 and #17819
License MIT

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Behat Issues and PRs aimed at improving Behat usage. labels Apr 2, 2025
@GSadee GSadee requested review from a team as code owners April 2, 2025 11:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

NoResponseMate
NoResponseMate reviewed Apr 2, 2025
View reviewed changes
...op/taxation/applying_taxes/applying_correct_taxes_for_items_with_different_tax_rates.feature
And I add product "Symfony Mug" to the cart
Given I added product "PHP T-Shirt" to the cart
And I added product "Symfony Mug" to the cart
And I check the details of my cart
Copy link
Copy Markdown
Contributor

@NoResponseMate NoResponseMate Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And I check the details of my cart
When I check the details of my cart

...op/taxation/applying_taxes/applying_correct_taxes_for_items_with_different_tax_rates.feature
And I add 4 products "Symfony Mug" to the cart
Given I added 3 products "PHP T-Shirt" to the cart
And I added 4 products "Symfony Mug" to the cart
And I check the details of my cart
Copy link
Copy Markdown
Contributor

@NoResponseMate NoResponseMate Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And I check the details of my cart
When I check the details of my cart

src/Sylius/Behat/Context/Setup/CartContext.php
* @Given /^I have ("[^"]+" variant of product "[^"]+") in the (cart)$/
* @Given /^I have ("[^"]+" variant of this product) in the (cart)$/
*/
#[Given('/^I added ("[^"]+" variant of product "[^"]+") to the (cart)$/')]
Copy link
Copy Markdown
Contributor

@NoResponseMate NoResponseMate Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the sudden change from have to added?

Copy link
Copy Markdown
Contributor

@Rafikooo Rafikooo Apr 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed this change because IMO it’s more precise — it clearly indicates that I, as the actor, added the product. Given I have could imply that the product was added in some other way.

@Rafikooo
Copy link
Copy Markdown
Contributor

Rafikooo commented Apr 2, 2025

I believe these minor improvements can be made in the next PR.

@Rafikooo Rafikooo merged commit c392102 into Sylius:2.0 Apr 2, 2025
26 checks passed
@GSadee GSadee deleted the SYL-4585-refactor-shop-taxation-scenarios branch April 2, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

@Rafikooo Rafikooo Rafikooo approved these changes

@mpysiak mpysiak mpysiak approved these changes

Assignees

No one assigned

Labels

Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GSadee @Rafikooo @NoResponseMate @mpysiak