[payment] allow set traversable as payment's details.#1608
Merged
pjedrzejewski merged 2 commits intoSylius:masterfrom Jun 21, 2014
Merged
[payment] allow set traversable as payment's details.#1608pjedrzejewski merged 2 commits intoSylius:masterfrom
pjedrzejewski merged 2 commits intoSylius:masterfrom
Conversation
Contributor
Author
|
for the referance Payum/PayumBundle#137 |
Contributor
Author
|
@pjedrzejewski can we do a BC break? wdyt about this? |
Contributor
|
Notes in |
Contributor
|
Yes, just please add some notes in the upgrade and I am fine with such BC break. Thanks! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jun 21, 2014
…aversable [payment] allow set traversable as payment's details.
Contributor
|
Thanks Maksim! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…low-traversable [payment] allow set traversable as payment's details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains BC break in
PaymentInterface::setDetailsmethod. Removing this gives us some advantages:$payment->setDetails((array) $details);PaymentInterfacein PayumBundle as unified layer for doing payments. I need these interfaces to be compatible to simplify things.Merge only after #1607 is merged