Skip to content

[payum] payum does not store details after user is returned from payment#1607

Merged
winzou merged 2 commits intoSylius:masterfrom
formapro-forks:payum-do-not-store-details-after-returning-back
Jun 12, 2014
Merged

[payum] payum does not store details after user is returned from payment#1607
winzou merged 2 commits intoSylius:masterfrom
formapro-forks:payum-do-not-store-details-after-returning-back

Conversation

@makasim
Copy link
Copy Markdown
Contributor

@makasim makasim commented Jun 12, 2014

fixes #1602 and probably #1605

/cc @winzou

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm?
Actually it should be $payment->getCurrenty() as we rely on payment and not order anymore.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, my bad, I put it for debug purpose here to avoid multi-currency issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in dbf8b76

winzou added a commit that referenced this pull request Jun 12, 2014
…ls-after-returning-back

[payum] payum does not store details after user is returned from payment
@winzou winzou merged commit 485c147 into Sylius:master Jun 12, 2014
@winzou
Copy link
Copy Markdown
Contributor

winzou commented Jun 12, 2014

Let's give it a try, thanks

@makasim makasim deleted the payum-do-not-store-details-after-returning-back branch June 12, 2014 09:27
@winzou
Copy link
Copy Markdown
Contributor

winzou commented Jun 12, 2014

All good!

@pjedrzejewski
Copy link
Copy Markdown
Contributor

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Payum] Not keeping failure details with Paypal

3 participants