[Payum] Not keeping failure details with Paypal #1602
Description
/cc @makasim
I have a failed payment with Paypal because Paypal checks the sum of all items against order total. This was wrong (because we're showing tax total as an item whereas I have tax included in price, it's another bug).
But Payum doesn't change my payment status, and doesn't keep this information that Paypal is returning me.
Some logs:
DEBUG - [Payum] 1# Payum\Core\Action\ExecuteSameRequestWithModelDetailsAction::execute(SecuredCaptureRequest{model: PaymentSecurityToken})
DEBUG - [Payum] 2# Caissin\CoreBundle\Payum\Paypal\Action\CapturePaymentOrderUsingExpressCheckoutAction::execute(SecuredCaptureRequest{model: Payment})
DEBUG - [Payum] 3# Payum\Paypal\ExpressCheckout\Nvp\Action\CaptureAction::execute(SecuredCaptureRequest{model: ArrayObject})
DEBUG - [Payum] 4# Payum\Paypal\ExpressCheckout\Nvp\Action\Api\SetExpressCheckoutAction::execute(SetExpressCheckoutRequest{model: ArrayObject})
DEBUG - [Payum] 4# SetExpressCheckoutAction::execute(SetExpressCheckoutRequest{model: ArrayObject}) throws exception HttpResponseAckNotSuccessException
See last payum debug.
And then it updates payment details with nothing more that what defined by CapturePaymentOrderUsingExpressCheckoutAction (= it does not include what Paypal returns, aka an error message).
I know it did before, so we broke something at some point.
Metadata
Metadata
Assignees
Labels
No labels