[PoC][Sylius] Reuse Sylius Payment model as unified way of doing payments.#137
Closed
makasim wants to merge 1 commit intoPayum:masterfrom
Closed
[PoC][Sylius] Reuse Sylius Payment model as unified way of doing payments.#137makasim wants to merge 1 commit intoPayum:masterfrom
makasim wants to merge 1 commit intoPayum:masterfrom
Conversation
Contributor
|
What is the purpose of this exactly? |
Member
Author
|
@winzou to have a unified model (hide payment specific details) that all payments would support. Like order in sylius. You can pass it to the payment and it takes care of it and return you a status. I am going to use Sylius's Payment model for that, but I am not sure it would be the final solution. |
Member
Author
|
It also provide a PaymentType form with three fields: amount, currency and payment select box. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.