[Feature:InstructorUI] Image Annotator Access via Filename Click#12207
Closed
Sourojitbanerjee wants to merge 2 commits intoSubmitty:mainfrom
Closed
[Feature:InstructorUI] Image Annotator Access via Filename Click#12207Sourojitbanerjee wants to merge 2 commits intoSubmitty:mainfrom
Sourojitbanerjee wants to merge 2 commits intoSubmitty:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12207 +/- ##
=========================================
Coverage 21.71% 21.71%
Complexity 9612 9612
=========================================
Files 268 268
Lines 36073 36073
Branches 475 475
=========================================
Hits 7832 7832
Misses 27770 27770
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RyanStyron
requested changes
Nov 14, 2025
Contributor
Author
|
Thank you! I've resolved the merge conflicts. Could you please approve the workflows and let me know if there are any specific CSS lint errors I need to fix? The feature is working as intended. |
RyanStyron
requested changes
Nov 16, 2025
Contributor
RyanStyron
left a comment
There was a problem hiding this comment.
This feature no longer works as popOutSubmittedFile was replaced by openSubmittedFile in #12135.
bmcutler
pushed a commit
that referenced
this pull request
Dec 15, 2025
### Why is this Change Important & Necessary? Closes #12000; supersedes #12207. As noted in the linked issue, clicking submission images to open the annotator directly is not currently a feature. Enabling the filename to be clicked to open the image/annotator better aligns usability with other submission types. ### What is the New Behavior? Clicking an image filename as requested by the linked issue is now functional. ### What steps should a reviewer take to reproduce or test the bug or new feature? (_Copied from superseded PR_) 1. Navigate to a submission with image files 2. Click on image filenames - should open annotator directly 3. Click on non-image filenames - should maintain original behavior 4. Verify both filename click and arrow button work correctly --------- Co-authored-by: Sourojit Banerjee <181811476+Sourojitbanerjee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #12000
Why is this Change Important & Necessary?
Allow clicking image filenames to open the annotator directly, improving usability by providing a larger click target alongside the existing arrow button.
What is the New Behavior?
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information