Skip to content

[Feature:InstructorUI] Click Image Filename to Access Annotator#12283

Merged
bmcutler merged 6 commits intomainfrom
image-filename-click
Dec 15, 2025
Merged

[Feature:InstructorUI] Click Image Filename to Access Annotator#12283
bmcutler merged 6 commits intomainfrom
image-filename-click

Conversation

@RyanStyron
Copy link
Contributor

Why is this Change Important & Necessary?

Closes #12000; supersedes #12207.
As noted in the linked issue, clicking submission images to open the annotator directly is not currently a feature. Enabling the filename to be clicked to open the image/annotator better aligns usability with other submission types.

What is the New Behavior?

Clicking an image filename as requested by the linked issue is now functional.

What steps should a reviewer take to reproduce or test the bug or new feature?

(Copied from superseded PR)

  1. Navigate to a submission with image files
  2. Click on image filenames - should open annotator directly
  3. Click on non-image filenames - should maintain original behavior
  4. Verify both filename click and arrow button work correctly

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.69%. Comparing base (6e5d06e) to head (0df295c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12283   +/-   ##
=========================================
  Coverage     21.69%   21.69%           
  Complexity     9618     9618           
=========================================
  Files           268      268           
  Lines         36113    36113           
  Branches        478      478           
=========================================
  Hits           7835     7835           
  Misses        27804    27804           
  Partials        474      474           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to In Review in Submitty Development Dec 15, 2025
Copy link
Contributor

@Rkoester47 Rkoester47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully upload a JPG to a gradeable, and then click the name of the file to open the image. No other functionality seems to be impacted by this PR, as clicking the arrow next to the filename still opens the image. Overall, this is a great quality of life update for this page.

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Dec 15, 2025
@RyanStyron RyanStyron moved this from Awaiting Maintainer Review to Ready to Merge in Submitty Development Dec 15, 2025
@bmcutler bmcutler merged commit 9f50316 into main Dec 15, 2025
26 checks passed
@bmcutler bmcutler deleted the image-filename-click branch December 15, 2025 20:16
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Submitty Development Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Make Annotatable Image File Names Clickable in Grader View

4 participants