[Feature:Submission] Open Submitted Files in New Tab#12135
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12135 +/- ##
=========================================
Coverage 21.73% 21.73%
Complexity 9598 9598
=========================================
Files 268 268
Lines 36006 36006
Branches 475 475
=========================================
Hits 7827 7827
Misses 27708 27708
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…-gradeable-files-in-new-tab
Rkoester47
left a comment
There was a problem hiding this comment.
I tested this branch, and clicking "View" on a submitted and graded homework file did open it in a new tab. I think this is a good idea and much more intuitive than opening the file in a separate pop up window in front of the Submitty page. As far as I can tell the files always open in a new tab now, as intended.
JManion32
left a comment
There was a problem hiding this comment.
This request is based on our meeting where we determined that this change is only for students who are trying to view their submitted files.
In the TA grading panel, there was an option to popout files (see highlighted):
Now, it opens them on a separate page, which is consistent with the new functionality, but may be beyond the scope of what this PR intends to do.
|
Updated changes to more accurately reflect intention of the PR. |
DarthNyan
left a comment
There was a problem hiding this comment.
Code changes look good.
JManion32
left a comment
There was a problem hiding this comment.
Code changes look good, this is a very positive change for student user experience!
Why is this Change Important & Necessary?
This change is to simplify user experience in cases where there are several files submitted for a given Gradeable. When
Viewis selected, the files now open in the same window as the one that is currently opened.What is the New Behavior?
Prior to the change, an uploaded file which was submitted could be viewed by a student in the Gradeable and would appear as follows:
When
Viewis clicked, a pop-up the contents of the file appear (in this case, the content of the file is text "Test file")With this change:
