feat: more hash, sizeof and eq implementations#609
feat: more hash, sizeof and eq implementations#609lars-reimann merged 16 commits intoSafe-DS:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 54 56 +2
Lines 3323 3493 +170
==========================================
+ Hits 3323 3493 +170 ☔ View full report in Codecov by Sentry. |
|
@lars-reimann The linter seems broken, it doesn't automatically push anything anymore |
Some errors cannot be fixed automatically. If there is at least one such error, no commit is created to fix the others. I'll look into whether it can create comments on PRs from forks, though. |
See this commit: 68c3562 (https://github.com/Safe-DS/Library/actions/runs/8553108748/job/23435588119). No errors are left, and the linter still does not push (although at least 22 fixes could be made). Maybe this is also a problem with the fork. |
Yep, it is. Workflows with the I've added you to the library team for now, so you have direct write access. |
|
Everything should be addressed now, I even learned that implementations of methods can be copied from the parent class (for deduplicating |
lars-reimann
left a comment
There was a problem hiding this comment.
The hash functions are very nice to read now. All looks good.
### Summary of Changes - shared memory - lazy comparisons - limited memory - value removal strategies - use deterministic seed for hashing Closes #44 Depends on Safe-DS/Library#609 --------- Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17) ### Features * add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570) * Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600) * more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a)) ### Performance Improvements * Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606) * improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610) * lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313)) * treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary of Changes